118352 - Javascript: window.print() broken, gives unexpected exception

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Luke Koleszar]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:0.9.7) Gecko/20011221
BuildID:    2001010403

Sometime around the 1st, window.print() stopped working and started giving the
following exception:
Error: uncaught exception: [Exception... "Not enough arguments
[nsIDOMWindowInternal.print]"  nsresult: "0x80570001
(NS_ERROR_XPC_NOT_ENOUGH_ARGS)"  location: "JS frame ::
https://www.retirementpassport.com:443/rss/servlet/ServiceDispatch/0304?state=group&stateTable=groupChange&event=moduleChange&moduleName=AccountInquiry
:: printWindow :: line 185"  data: no]

Reproducible: Always
Steps to Reproduce:
Go to given URL, press "Print this Page" button

Actual Results:
Exception in javascript console

Expected Results:
Print dialog

I first noticed this problem on an investment web site with 2002010403, but was
able to reproduce it at the URL given above.

Works with 0.9.7
Works with 20011231
               <--- regression point
Broken with 20020101
Broken with 20020102
Broken with 20020104

Comment 1

[Boris Zbarsky [:bzbarsky]]

To Rod, who checked in printing stuff right around then.

Comment 2

[Johnny Stenback (:jst)]

Attachment: Proposed fix

Comment 3

[Johnny Stenback (:jst)]

Attachment: Proposed fix (diff -w)

Comment 4

[Johnny Stenback (:jst)]

Reviews?

Comment 5

[rods (gone)]

Attachment: patch

I was a little over zealous on where I was adding the PrintSettings as
arguments to interfaces. This patch simply removes the nsIPRintSettings from
the nsIDOMWindowInternal interface.

jst, does you patch fix a different bug?

Comment 6

[Johnny Stenback (:jst)]

Nope, my patch fixed an exception from the same code, but in an older version of
the code, the world changed underneeth my feet here. My patch doesn't seem to
apply at all any more.

Ignore my patches.

Comment 7

[Johnny Stenback (:jst)]

Comment on attachment 64523 [details] [diff] [review]
patch

sr=jst

Comment 8

[dcone (gone)]

Comment on attachment 64523 [details] [diff] [review]
patch

r=dcone

Comment 9

[rods (gone)]

fixed

Comment 10

[Johnny Stenback (:jst)]

*** Bug 119873 has been marked as a duplicate of this bug. ***

Comment 11

[rods (gone)]

This fixed the generic problem bu broken print with the currently page setup
options.

Comment 12

[rods (gone)]

Attachment: new patch to fix both problems

The issue is that generic JS needs to be able to call print with no params and
the browser needs to be able to call it with the print options. The "print"
with the print options is something we need to use so I gave it a separate and
unique name.

Comment 13

[dcone (gone)]

Comment on attachment 64868 [details] [diff] [review]
new patch to fix both problems

r=dcone

Comment 14

[Johnny Stenback (:jst)]

Comment on attachment 64868 [details] [diff] [review]
new patch to fix both problems

sr=jst

Comment 15

[rods (gone)]

Attachment: The correct patch

Added new method printWithSettings for printing with passing in PrintSettings

Comment 16

[rods (gone)]

fixed

Comment 17

[Johnny Stenback (:jst)]

Comment on attachment 64933 [details] [diff] [review]
The correct patch

sr=jst