Closed Bug 1183609 Opened 9 years ago Closed 9 years ago

[Control Center] Should use an attribute instead of CSS classes for different security states

Categories

(Firefox :: General, defect, P1)

Product:
Firefox
Component:
General
Type:
defect
Points:
3

Tracking

()

Status:
RESOLVED FIXED
Iteration:
42.3 - Aug 10
Tracking Flags:
Tracking Status
firefox42 --- affected

People

(Reporter: ttaubert, Assigned: ttaubert)

References

Details

(Whiteboard: [fxprivacy] [campaign]) 

(In reply to :Gijs Kruitbosch from comment #2)
> It seems like really, for all of these, an attribute would be neater (e.g.
> .setAttribute("seclevel", "chrome") or something) and would have fewer risks
> in terms of interfering with other attempts to style things.

We could for example get rid of <vbox id=tracking-protection-content> as that only exists because we're currently using classes to style different states, and that would have overriden ".identity-popup-section" of the parent container.
Flags: firefox-backlog?
Whiteboard: [fxprivacy]
Flags: firefox-backlog? → firefox-backlog+
Priority: -- → P2
Thinking about addressing some of this in bug 1175702 as it's getting messy.
Will fix this over in bug 1175702.
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Iteration: --- → 42.2 - Jul 27
Points: --- → 3
Depends on: 1175702
Flags: qe-verify-
Blocks: 1174986
Rank: 2
Priority: P2 → P1
Whiteboard: [fxprivacy] → [fxprivacy] [campaign]
Iteration: 42.2 - Jul 27 → 42.3 - Aug 10
Fixed by Bug 1175702.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.