1183623 - [e10s] URL bar input is ignored when a specific page is loaded

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

STR:

1) Open a new tab
2) Paste http://www.duden.de/rechtschreibung/institutionell and load it
3) Hit Cmd+L to focus the URL bar
4) Enter "asdf "asdf" or an actualy URL and hit Return

The sites takes you to http://www.duden.de/suchen/dudenonline?scope=all&s= instead of searching for "asdf asdf" or taking you to the URL.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Seems to happen only with e10s enabled. Would love to investigate this more but I don't have a lot of time currently, sorry.

Comment 2

[Tracy Walker [:tracy]]

yes, reproducible. This seems familiar, but a quick search didn't find a dupe.

Comment 3

[Sören Hentzschel]

Maybe related, I reported a similar bug two years ago:
https://bugzilla.mozilla.org/show_bug.cgi?id=966151

It's reproducible with e10s *disabled*.

Comment 4

[Neil Deakin]

Attachment: Testcase

Steps:

1. Open the attached.
2. Click in the input field and then in the location bar
3. Type some text and press enter

The issue is that the page receives the key event when it should not do.

Comment 5

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Do you want to take this bug Neil? I haven't started working on it.

Comment 6

[Neil Deakin]

I think what happens here is that:

1. The user presses Enter. The location bar receives a keydown event.
2. This causes the search to start and the content to get focused.
3. The keyup event then fires at the newly focused content.

Holding the enter key down causes this to work of course.

Comment 7

[Neil Deakin]

Sure, I'll take this. In fact I just figured out the code causing the bug and will work on a fix on Monday.

Comment 8

[Neil Deakin]

Attachment: Check for a TabParent as well as a content document

Comment 9

[Neil Deakin]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/1dfc7dab518c72b7541ee325480e80f88642645f
changeset:  1dfc7dab518c72b7541ee325480e80f88642645f
user:       Neil Deakin <[e-mail]>
date:       Thu Jul 23 10:04:19 2015 -0400
description:
Bug 1183623, redirect keyup events to keydown target when focus shifts from chrome to content in-between, r=smaug

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1dfc7dab518c