1183687 - [gaia-switch] 'type' getter called on an object that does not implement interface HTMLInputElement.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Components, defect)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

I'm experimenting with various types of automation testing available for a11y, to be possibly used for our gaia-components. One issue I found was related to the inheritance from the HTMLElements, in case of gaia-switch, from HTMLInputElement (it drives some of the tests).

It seems like there's an issue accessing its type getter, and it might be a bug.
HTMLInputElement.type runs without error but
HTMLInputElement.prototype.type throws:
'type' getter called on an object that does not implement interface HTMLInputElement. which is what happens if we call gaiaSwitchObject.type

If this is not a bug, feel free to close the bug.

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Wilson, have you seen the above issue with any of our components? 
Also it looks like if we were to registerElement with extends instead of prototype it seems to work as expected.

Comment 2

[[e-mail]]

register with option {extends: } was not work with gecko's custom element implementation.

gaia-component's `extends` attribute is actually the prototype. 


Is HTMLInputElement.type is called inside of component?

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Fred Lin [:gasolin] from comment #2)
> register with option {extends: } was not work with gecko's custom element
> implementation.

yeah

> 
> gaia-component's `extends` attribute is actually the prototype. 
> 
> 
> Is HTMLInputElement.type is called inside of component?

Not inside the component, but by the automated testing tools (e.g. external).

Comment 4

[Wilson Page [:wilsonpage]]

It seems like the simplest fix for this is to remove this line [1]. IIRC Fred added this. Fred is there any issue if we remove this?

[1] https://github.com/gaia-components/gaia-switch/blob/master/gaia-switch.js#L22

Comment 5

[[e-mail]]

I added this for general accessibility concern (but it seems not work well :( ), its fine to remove this if it does not help the accessibility.

Comment 6

[Wilson Page [:wilsonpage]]

(In reply to Fred Lin [:gasolin] from comment #5)
> I added this for general accessibility concern (but it seems not work well
> :( ), its fine to remove this if it does not help the accessibility.

OK let's strip this for the time being if it fixes this? Yzen?

Comment 7

[Yura Zenevich [:yzen] (please use "needinfo")]

Yes in this case it should probably be removed, especially since we do not specify the type.

Comment 8

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Github pull request.

Comment 9

[Wilson Page [:wilsonpage]]

Comment on attachment 8640726 [details] [review]
Github pull request.

LANDED