1183730 - Sync migration warning icon not displayed properly in Hamburger menu

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Edouard Oger [:eoger]]

The warning icon is not displayed because we didn't update the CSS rules

Comment 1

[Edouard Oger [:eoger]]

Attachment: bug-1183730.patch

Comment 2

[Edouard Oger [:eoger]]

Attachment: bug-1183730.patch

And we also had a typo in one of the images path!

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/5e0ce7658eaa

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5e0ce7658eaa

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8633582 [details] [diff] [review]
bug-1183730.patch

Approval Request Comment
[Feature/regressing bug #]: 1139698
[User impact if declined]: The "warning" icon when FxA is in an error state isn't shown when it should be.
[Describe test coverage new/current, TreeHerder]: Existing tests pass
[Risks and why]: None
[String/UUID change made/needed]: None

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Mark, could you please verify that this fix works for you? I would like to approve it for uplift to Aurora and since it only landed in m-c a day or two ago, if I get a "verified" from you, I can give it the green signal today. Thanks!

Comment 7

[Mark Hammond [:markh] [:mhammond]]

I can't see this work on 42.0a1 (2015-07-21) for some reason. The Inspector tool also isn't showing me that ::after rules for the element and I'm not sure if this is a limitation in the inspector (I'm sure it does show them on content) or a reflection of why I can't see them.

:eoger, can you please have a look?

Comment 8

[Mark Hammond [:markh] [:mhammond]]

(In reply to Mark Hammond [:markh] from comment #7)
> Hrm - but I do see it work correctly locally built. Hopefully tomorrow's nightly will have it?

Comment 9

[Mark Hammond [:markh] [:mhammond]]

Ritu, I can verify this is working as expected on Nightly, so ni? to address the uplift request.

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8633582 [details] [diff] [review]
bug-1183730.patch

Mark has verified the fix on nightly. Safe to land on Aurora.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2215a2684211

Comment 12

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Setting as Verified for Nightly based on comment 9.