1183809 - Suggested sites have hard-coded english titles

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

The two suggested sites that we include in the app, 'The Mozilla Project' and 'Firefox Help and Support' have hardcoded English titles.

Three options for v1:

* We leave it as is
* We localize the titles
* We remove the titles

Comment 1

[Richard Newman [:rnewman]]

IMO: if it's technically feasible to localize, we should.

If it's not, and the tiles aren't pictographically descriptive enough, then we should switch the titles to the least English strings they can be:

  "Mozilla Project"
  "Support" (or "Help")

Comment 2

[Wesley Johnston (:wesj)]

I'd vote for removing titles here. I'd also vote for more pictographic images.

Comment 3

[Wesley Johnston (:wesj)]

Looking at Fennec's generator:

http://mxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/action/generate_suggestedsites.py#10

it sounds like l10n should have these tiles in their region.properties. Searching http://mxr.mozilla.org/l10n-central/ for any browser.suggestedsites (or even just suggestedsites) keys returns nothing though, so I assume these aren't localized there (testing confirmed!)

Given Android doesn't localize these, I don't think we should block v1 on it. Opinions?

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Moved this to 1.1. Not spending time on it for v1.0.

Comment 6

[James Hugman [:jhugman] [@jhugman]]

Attachment: Replace json array with array of structs.

Comment 7

[Stephan Leroux [:sleroux]]

Comment on attachment 8662138 [details] [review]
Replace json array with array of structs.

LGTM!

Comment 8

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8662138 [details] [review]
Replace json array with array of structs.

Don't localize the URLs. Just the titles. The URL will auto-redirect to the correct locale. There is nothing to localize for the L10N team there.

This can land when those strings are turned into regular non-localized ones.

Comment 9

[James Hugman [:jhugman] [@jhugman]]

Comment on attachment 8662138 [details] [review]
Replace json array with array of structs.

Addressed nits.

Comment 10

[James Hugman [:jhugman] [@jhugman]]

No longer localizing URLs.

Landed.