Closed Bug 1183809 Opened 9 years ago Closed 9 years ago

Suggested sites have hard-coded english titles

Categories

(Firefox for iOS :: Home screen, defect)

All
iOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
fxios 1.1+ ---

People

(Reporter: st3fan, Assigned: jhugman)

References

Details

(Whiteboard: [needs strings])

Attachments

(1 file)

The two suggested sites that we include in the app, 'The Mozilla Project' and 'Firefox Help and Support' have hardcoded English titles.

Three options for v1:

* We leave it as is
* We localize the titles
* We remove the titles
Depends on: 1177613
IMO: if it's technically feasible to localize, we should.

If it's not, and the tiles aren't pictographically descriptive enough, then we should switch the titles to the least English strings they can be:

  "Mozilla Project"
  "Support" (or "Help")
Component: General → Home screen
Hardware: Other → All
I'd vote for removing titles here. I'd also vote for more pictographic images.
Assignee: nobody → wjohnston
Looking at Fennec's generator:

http://mxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/action/generate_suggestedsites.py#10

it sounds like l10n should have these tiles in their region.properties. Searching http://mxr.mozilla.org/l10n-central/ for any browser.suggestedsites (or even just suggestedsites) keys returns nothing though, so I assume these aren't localized there (testing confirmed!)

Given Android doesn't localize these, I don't think we should block v1 on it. Opinions?
Moved this to 1.1. Not spending time on it for v1.0.
Assignee: wjohnston → nobody
Blocks: iosl10n
Assignee: nobody → jhugman
Whiteboard: [needs strings]
Attachment #8662138 - Flags: review?(sleroux)
Attachment #8662138 - Flags: review?(sarentz)
Blocks: 1204452
Blocks: 1204453
Status: NEW → ASSIGNED
Comment on attachment 8662138 [details] [review]
Replace json array with array of structs.

LGTM!
Attachment #8662138 - Flags: review?(sleroux) → review+
Comment on attachment 8662138 [details] [review]
Replace json array with array of structs.

Don't localize the URLs. Just the titles. The URL will auto-redirect to the correct locale. There is nothing to localize for the L10N team there.

This can land when those strings are turned into regular non-localized ones.
Comment on attachment 8662138 [details] [review]
Replace json array with array of structs.

Addressed nits.
No longer localizing URLs.

Landed.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Attachment #8662138 - Flags: review?(sarentz) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: