Closed
Bug 1183813
Opened 9 years ago
Closed 9 years ago
PushEvent PushMessageData should be the same instance every time.
Categories
(Core :: DOM: Push Subscriptions, defect)
Core
DOM: Push Subscriptions
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: nsm, Assigned: nsm)
References
Details
Attachments
(1 file)
pushEvent.data == pushEvent.data always.
|
Assignee | |
Comment 1•9 years ago
|
||
Bug 1183813 - PushEvent.data should be same instance every time. r?smaug
Attachment #8633682 -
Flags: review?(bugs)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8633682 [details] MozReview Request: Bug 1183813 - PushEvent.data should be same instance every time. r?smaug Cycle collection part missing?
Attachment #8633682 -
Flags: review?(bugs) → review-
|
|
Assignee | |
Comment 3•9 years ago
|
||
Comment on attachment 8633682 [details] MozReview Request: Bug 1183813 - PushEvent.data should be same instance every time. r?smaug Bug 1183813 - PushEvent.data should be same instance every time. r?smaug
Attachment #8633682 -
Flags: review- → review?(bugs)
|
|
Assignee | |
Comment 4•9 years ago
|
||
I guess that is why the original code always created a new instance, to avoid CC ;)
|
|
||
Updated•9 years ago
|
Attachment #8633682 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
url: https://hg.mozilla.org/integration/mozilla-inbound/rev/a85971b21cf7290ea425c95f63607ec65da03b22 changeset: a85971b21cf7290ea425c95f63607ec65da03b22 user: Nikhil Marathe <nsm.nikhil@gmail.com> date: Tue Jul 14 13:10:58 2015 -0700 description: Bug 1183813 - PushEvent.data should be same instance every time. r=smaug
|
||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a85971b21cf7
Assignee: nobody → nsm.nikhil
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•