1183837 - "Tab closed" toast no longer truncates page title

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

I'm not sure when this started happening, but now the toast is variable height which looks pretty weird.

We should fix this.

STR:

Open a tab
Open tabs tray
Dismiss a tab
see undo toast

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Any idea here Mike?

Comment 2

[Chenxia Liu [:liuche]]

Bug 1167360 regressed this, and changed the maxLines to 3, and removed the ellipsis. There's a comment (#9) about checking with UX for feedback, but looks like it got forgotten and landed anyways. :aminb, would you fix this and write a patch to revert the maxlines and ellipsis changes?

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Just making sure this won't roll over to Aurora.

Comment 4

[Chenxia Liu [:liuche]]

Attachment: MozReview Request: Bug 1183837 - "Tab closed" toast no longer truncates page title. r=mcomella

Bug 1183837 - "Tab closed" toast no longer truncates page title. r=mcomella

Comment 5

[Chenxia Liu [:liuche]]

This is actually already in Aurora so I'm just going to fix it and uplift.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8650739 [details]
MozReview Request: Bug 1183837 - "Tab closed" toast no longer truncates page title. r=mcomella

https://reviewboard.mozilla.org/r/16673/#review14949

Bug 1167360 comment 9 says the change was questionable and we should have UX guidance but none was received so I'm guessing the original change just wasn't thought through – wfm.

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Oh, comment 2 already had my info from comment 6 – I should read more! Thanks Chenxia! :)

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/c569ca830c25

Comment 9

[Chenxia Liu [:liuche]]

Comment on attachment 8650739 [details]
MozReview Request: Bug 1183837 - "Tab closed" toast no longer truncates page title. r=mcomella

Approval Request Comment
[Feature/regressing bug #]: Bug 1167360 regressed this by making some changes that slipped through UX review
[User impact if declined]: Toast can look very large and inconsistent with other toasts
[Describe test coverage new/current, TreeHerder]: local testing
[Risks and why]: very low, reverting two properties in a style file
[String/UUID change made/needed]: none

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c569ca830c25

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Anthony, could you please verify the fix on 8/21 Nightly or later? This patch just landed on m-c today. I would like to get your confirmation if possible before uplifting to Beta41. Thanks.

Comment 12

[Chenxia Liu [:liuche]]

FYI, the nightly OTA update will not include this change until 8/22 if it just landed this morning - I got my 8/21 before this merged to m-c.

Comment 13

[Chenxia Liu [:liuche]]

Attachment: Screenshot: toast

You can't see the outline of the toast, but that's because of the toast background color/opacity bug. This is just for the text truncation.

Comment 14

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

nicely saved! I tested on today's nightly (22nd) and it looks as is in the screenshot you posted.

Thanks Chenxia!

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8650739 [details]
MozReview Request: Bug 1183837 - "Tab closed" toast no longer truncates page title. r=mcomella

Let's take this probably safe fix.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5894913e4259

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a9d637399efc

Comment 18

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Marking it verified based on comment 14.

Comment 19

[u421692]

Verified as fixed on Firefox 41 Beta 4, and on latest Aurora