Closed Bug 1183837 Opened 5 years ago Closed 5 years ago

"Tab closed" toast no longer truncates page title

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 43
Tracking Status
firefox41 --- verified
firefox42 --- verified
firefox43 --- verified

People

(Reporter: antlam, Assigned: liuche, Mentored)

Details

(Whiteboard: [good first bug][lang=java])

Attachments

(2 files)

I'm not sure when this started happening, but now the toast is variable height which looks pretty weird.

We should fix this.

STR:

Open a tab
Open tabs tray
Dismiss a tab
see undo toast
Any idea here Mike?
Flags: needinfo?(michael.l.comella)
Bug 1167360 regressed this, and changed the maxLines to 3, and removed the ellipsis. There's a comment (#9) about checking with UX for feedback, but looks like it got forgotten and landed anyways. :aminb, would you fix this and write a patch to revert the maxlines and ellipsis changes?
Flags: needinfo?(michael.l.comella) → needinfo?(me)
Just making sure this won't roll over to Aurora.
Flags: needinfo?(liuche)
Bug 1183837 - "Tab closed" toast no longer truncates page title. r=mcomella
Attachment #8650739 - Flags: review?(michael.l.comella)
This is actually already in Aurora so I'm just going to fix it and uplift.
Mentor: liuche
Flags: needinfo?(me)
Flags: needinfo?(liuche)
Whiteboard: [good first bug][lang=java]
Assignee: nobody → liuche
Comment on attachment 8650739 [details]
MozReview Request: Bug 1183837 - "Tab closed" toast no longer truncates page title. r=mcomella

https://reviewboard.mozilla.org/r/16673/#review14949

Bug 1167360 comment 9 says the change was questionable and we should have UX guidance but none was received so I'm guessing the original change just wasn't thought through – wfm.
Attachment #8650739 - Flags: review?(michael.l.comella) → review+
Oh, comment 2 already had my info from comment 6 – I should read more! Thanks Chenxia! :)
Comment on attachment 8650739 [details]
MozReview Request: Bug 1183837 - "Tab closed" toast no longer truncates page title. r=mcomella

Approval Request Comment
[Feature/regressing bug #]: Bug 1167360 regressed this by making some changes that slipped through UX review
[User impact if declined]: Toast can look very large and inconsistent with other toasts
[Describe test coverage new/current, TreeHerder]: local testing
[Risks and why]: very low, reverting two properties in a style file
[String/UUID change made/needed]: none
Attachment #8650739 - Flags: approval-mozilla-beta?
Attachment #8650739 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/c569ca830c25
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Anthony, could you please verify the fix on 8/21 Nightly or later? This patch just landed on m-c today. I would like to get your confirmation if possible before uplifting to Beta41. Thanks.
Flags: needinfo?(alam)
FYI, the nightly OTA update will not include this change until 8/22 if it just landed this morning - I got my 8/21 before this merged to m-c.
Attached image Screenshot: toast
You can't see the outline of the toast, but that's because of the toast background color/opacity bug. This is just for the text truncation.
Attachment #8651153 - Flags: review?(alam)
nicely saved! I tested on today's nightly (22nd) and it looks as is in the screenshot you posted.

Thanks Chenxia!
Flags: needinfo?(alam)
Attachment #8651153 - Flags: review?(alam) → review+
Comment on attachment 8650739 [details]
MozReview Request: Bug 1183837 - "Tab closed" toast no longer truncates page title. r=mcomella

Let's take this probably safe fix.
Attachment #8650739 - Flags: approval-mozilla-beta?
Attachment #8650739 - Flags: approval-mozilla-beta+
Attachment #8650739 - Flags: approval-mozilla-aurora?
Attachment #8650739 - Flags: approval-mozilla-aurora+
Marking it verified based on comment 14.
Status: RESOLVED → VERIFIED
Verified as fixed on Firefox 41 Beta 4, and on latest Aurora
You need to log in before you can comment on or make changes to this bug.