1183854 - Switch order of Logviewer header/failure steps containers

Status: RESOLVED WONTFIX

(Tree Management :: Treeherder, defect, P3)

Description

[Jonathan French (:jfrench)]

Jgriffin posed that users interact with the Logviewer failure steps container first and more frequently, so he suggested reversing the layout order of the main Logviewer containers, to be:

Failure/Success Steps | Meta/Job Header Info

This is sort of opposite to the layout style from the main Treeherder panel where the Job Details is left side and the interactive task-like 'stuff' like suggested failures are on the right, but we've no need to adhere to that consistency in Logviewer if there's a clear UX win.

Adding a few folks for feedback and opinion, and since we have so many users we want to be careful it's not perceived as an arbitrary switch.

Comment 1

[Jonathan French (:jfrench)]

Adding a few need info's, hopefully I haven't over solicited.

A note this is just part of a broader amount of proposed work for Logviewer in meta bug 1182178.

Comment 2

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

I don't really interact with the log viewer UI much. As long as my logs show up properly, I'm happy.

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Screenshot

Hmm, so this?

Other than being opposed to breaking muscle memory after using it the other way for a year or so, I'm mostly indifferent.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

As an aside, I think it'd be okay to move those two buttons so they're under the job details section instead of the failure steps. That should hopefully free up like half an inch or so of vertical space for the actual log viewer.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

personally I just use the raw logs, so moving this wouldn't affect me.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

I'm having a hard time justifying breaking muscle memory over this. I can't recall ever hearing any devs complaining about it either.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

No opinion from me.

Comment 8

[Phil Ringnalda (:philor)]

Doesn't seem worth doing to me, but if it's done I won't have much trouble adapting.

Comment 9

[Jonathan Griffin (:jgriffin)]

Seems like not much love for this, let's not do it.