1183867 - Fix PushSubscription.unsubscribe() semantics

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, defect)

Description

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

resolve with false when subscription does not exist. true when successfully unregistered. reject with NetworkError in other cases.

Comment 1

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: MozReview Request: Bug 1183867 - Fix PushSubscription.unsubscribe() semantics r?mt

Bug 1183867 - Fix PushSubscription.unsubscribe() semantics r?mt

resolve with false when subscription does not exist. true when successfully unregistered. reject with NetworkError in other cases.

Comment 2

[Martin Thomson [:mt:]]

Comment on attachment 8633722 [details]
MozReview Request: Bug 1183867 - Fix PushSubscription.unsubscribe() semantics r?mt

https://reviewboard.mozilla.org/r/13257/#review11887

Ship It!

::: dom/push/PushService.jsm:961
(Diff revision 1)
> -        ]);
> +        ]).then(function() {
> +          return true;
> +        });

`_ => true` or `() => true`

Comment 3

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/0560abdc67cf6b249101da32ad6af4580990addb
changeset:  0560abdc67cf6b249101da32ad6af4580990addb
user:       Nikhil Marathe <[e-mail]>
date:       Tue Jul 14 15:01:41 2015 -0700
description:
Bug 1183867 - Fix PushSubscription.unsubscribe() semantics r=mt

resolve with false when subscription does not exist. true when successfully unregistered. reject with NetworkError in other cases.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0560abdc67cf