Closed
Bug 1183870
Opened 9 years ago
Closed 9 years ago
[B2G] Set current audio channel to "none" when there is no any audio playing
Categories
(Firefox OS Graveyard :: Gaia::System::Audio Mgmt, defect)
Tracking
(blocking-b2g:2.5+, b2g-v2.2 unaffected, b2g-master verified)
Tracking | Status | |
---|---|---|
b2g-v2.2 | --- | unaffected |
b2g-master | --- | verified |
People
(Reporter: onelson, Assigned: evanxd)
References
()
Details
(Keywords: regression, Whiteboard: [2.5-Daily-Testing], [Spark])
Attachments
(4 files)
Description: When the user navigates to the browser to search 'www.youtube.com', they may experience the phone demonstrating unintended effects when attempting to adjust volume buttons via the phone's hardware buttons. On tapping the volume button on a website (such as youtube), the user may observe observe that the buttons will adjust the 'ringtone' volume/audiochanel as opposed to the 'media' volume which is either actively being used, or has the potential to be seen shortly. Could be involved with adjusting ringtone volume prior to entering browser. Repro Steps: 1) Update the device to [] 2) Open the browser app 3) Navigate to 'www.youtube.com' 4) Select the video 'Shake it Off by Taylor Swift' on the front page [or anything] 5) Adjust the volume via hardware buttons; observe volume drop down adjusting 6) Tap video play to start 7) Repeat step 5 Actual: Adjusting volume via hardware buttons in browser adjusts the ringtone volume Expected: Adjusting volume via hardware buttons in browser adjusts the media volume Environment Variables: --------------------------- Device: Aries 2.5 BuildID: 20150714110444 Gaia: 66638d0e65bf58b7f640bcc7bed4a0b23d1356c6 Gecko: e786406bc683 Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd Version: 42.0a1 (2.5) Firmware Version: D5803_23.1.A.1.28_NCB.ftf User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0 Device: Flame 2.5 BuildID: 20150714010206 Gaia: 7676b68b4d32ed13243eeb719188847121bd5611 Gecko: 0931671a14ef Gonk: a4f6f31d1fe213ac935ca8ede7d05e47324101a4 Version: 42.0a1 (2.5) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0 **************************** Issue DOES NOT REPRODUCE on 2.2 for flame devices Results: Adjusting volume via hardware buttons in browser adjusts the media volume Device: Flame 2.2 BuildID: 20150714002501 Gaia: 84d0c76370dcd3d25813b00de55194730884355b Gecko: a5db6d9850f6 Gonk: bd9cb3af2a0354577a6903917bc826489050b40d Version: 37.0 (2.2) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0 -------------------------- Repro Rate: 5/10 Attachments: video- https://youtu.be/mJDIYKTehmQ logcat
Reporter | ||
Updated•9 years ago
|
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(pbylenga)
Updated•9 years ago
|
Assignee: nobody → alwu
Comment 1•9 years ago
|
||
[Blocking Requested - why for this release]: Functional regression of a core feature. Requesting a window.
blocking-b2g: --- → 2.5?
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(pbylenga)
Keywords: regressionwindow-wanted
Comment 2•9 years ago
|
||
I was unable to reproduce this issue on the latest or the reporters build. Leaving the tags for someone else to attempt. Environmental Variables: Device: Flame 2.5 BuildID: 20150715195729 Gaia: 981c61cdeb527fac8f8383c110df0e749eff67ea Gecko: 72835344333f Version: 42.0a1 (2.5) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0
Flags: needinfo?(ktucker)
Updated•9 years ago
|
Flags: needinfo?(ktucker)
Comment 3•9 years ago
|
||
Adding more consistent steps to reproduce. Repro Steps: 1) Update an Aries to 20150716033647 2) Go to Settings > Sound 3) Adjust either the Ringtones & Notifications slider, or the Alarm volume slider. 4) Open the Browser, go to youtube, and play a video. 5) Adjust volume with the hardware buttons. Actual: Volume is adjusted for the audio channel from step 3. Expected: Volume is adjusted for the Media channel. Environmental Variables: Device: Aries 2.5 BuildID: 20150716033647 Gaia: 981c61cdeb527fac8f8383c110df0e749eff67ea Gecko: 72835344333f Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd Version: 42.0a1 (2.5) Firmware Version: D5803_23.1.A.1.28_NCB.ftf User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0
Assignee | ||
Updated•9 years ago
|
Assignee: alwu → evanxd
Comment 4•9 years ago
|
||
It seems that we forgot to change the current audio channel when the audio playback end, so the sound manager would send the wrong sound type event. Evan would take this bug.
Assignee | ||
Updated•9 years ago
|
Component: AudioChannel → Gaia::System::Audio Mgmt
Comment 5•9 years ago
|
||
Assignee | ||
Comment 6•9 years ago
|
||
The attachment 8635177 [details] [review] is a WIP patch.
Assignee | ||
Comment 8•9 years ago
|
||
Updated patch and added tests[1]. The treeherder: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=be3ce1d608274d79ad51998dbfc758c43549cbd3 [1]: https://github.com/evanxd/gaia/commit/be3ce1d608274d79ad51998dbfc758c43549cbd3
Assignee | ||
Comment 9•9 years ago
|
||
Comment on attachment 8635177 [details] [review] [gaia] evanxd:bug-1183870 > mozilla-b2g:master Hi Dominic, Could you help to review the patch? Thanks.
Attachment #8635177 -
Flags: review?(dominic.kuo)
Comment 10•9 years ago
|
||
Removing regression window wanted since there is already a patch. Adding qa wanted to test this again once it lands.
Keywords: regressionwindow-wanted → qawanted
Comment 11•9 years ago
|
||
Comment on attachment 8635177 [details] [review] [gaia] evanxd:bug-1183870 > mozilla-b2g:master Assuming I understand correctly, the audio channel service did not fire events when some audio channel ends, then caused this issue. This patch fires `audiochannelchanged` on both some audio channel starts or ends, so the patch looks good to me.
Attachment #8635177 -
Flags: review?(dominic.kuo) → review+
Assignee | ||
Comment 12•9 years ago
|
||
Dominic, thanks for the review.
Assignee | ||
Comment 13•9 years ago
|
||
master: https://github.com/mozilla-b2g/gaia/commit/b79d2a4c233d1e92790062219ebb7772965e1d56
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 14•9 years ago
|
||
Sorry had to revert this change since this caused Gij4 Test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=2346707&repo=b2g-inbound
Status: RESOLVED → REOPENED
Flags: needinfo?(evanxd)
Resolution: FIXED → ---
Assignee | ||
Comment 15•9 years ago
|
||
Hi Carsten, The Gij4 was good when I landed the code. See it[1]. But let me try again. [1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=be3ce1d608274d79ad51998dbfc758c43549cbd3
Flags: needinfo?(evanxd)
Comment 16•9 years ago
|
||
Assignee | ||
Comment 17•9 years ago
|
||
If the treeherder[1] is without any failure, let's land the code. [1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=bbce8a360b2391686c3244e19d29025e4ffbedaa
Assignee | ||
Comment 18•9 years ago
|
||
Two more treeherder tries[1][2]. [1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=6643f18c52a87feded6746569d49f44d03954326 [2]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=238030bc10e77ab7e819ef7620015727b0552cf1
Assignee | ||
Comment 19•9 years ago
|
||
New try: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=37d4ac7d5e52c0573e2c4d1d081693b90605f158
Updated•9 years ago
|
Summary: [Browser][AudioChannel] While on 'www.youtube.com', adjusting volume buttons may manipulate 'Ringtone' volume levels instead of 'Media' → [B2G] Send the "none" event when there is no any audio playing
Updated•9 years ago
|
Summary: [B2G] Send the "none" event when there is no any audio playing → [B2G] Set current audio channel to "none" when there is no any audio playing
Assignee | ||
Comment 22•9 years ago
|
||
new try: [1][2] [1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=3b7457d0d1080d3ed8f8520372b4ae9dc78f499a [2]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=698f2a3fca8f27b41afaa7eb9f8772c8c73a2b23
Assignee | ||
Comment 24•9 years ago
|
||
Cannot run the failed test in local. It's very hard to debug. Will try run it in local again later.
Assignee | ||
Comment 25•9 years ago
|
||
Sad, the test is passed in local. Need to debug this on CI server.
Assignee | ||
Comment 26•9 years ago
|
||
Debugging the failed test: https://github.com/evanxd/gaia/commit/cd0a6728b891594932c3c81940f1ebbd090d057a
Assignee | ||
Comment 27•9 years ago
|
||
Very weird, the play button on status bar is just disappeared.
Assignee | ||
Comment 28•9 years ago
|
||
Continue to debug on Treeherder[1][2][3] [1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=b21fb93c6cdd5e5bf4f71d15030888726349dec5 [2]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=cb1ac1db315366d36bcfcfce426c0a4dbb1334fc [3]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=d39a68ebff39b6ab9fdca1e8485b933505ede8e9
Assignee | ||
Comment 29•9 years ago
|
||
Finally, I found the root cause. Looks like it is about gecko. There are two issues here: 1. The music for `Check the play icon is in the status bar. moztrap:9742` test cannot be played in the runtime. 2. When the test does going homescreen, the state of the music just becomes `inactive`. And audio channel service will do `this.publish('audiochannelchanged', { channel: 'none' });`. So the play button in status bar is hidden. The above second issue is why the test cannot be passed. Let's file a bug for the gecko issues. And the bug blocks this bug.
Assignee | ||
Comment 30•9 years ago
|
||
The test will be passed after bug 1191207 is fixed. The we can land the code to fix this bug.
Depends on: 1191207
Comment 33•9 years ago
|
||
Hi, Evan, Because the bug1195191 was fixed, you can try the test again.
Flags: needinfo?(evan)
Assignee | ||
Comment 34•9 years ago
|
||
Thanks, Alastor. I've pushed my patch again, and the CI result[1][2][3]. Once the CI is good, we can land the code. [1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=e2fc9f84501ae5dcdb7b8148df3f871240c0e09f [2]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=8a14827167cb2dbfdf74a049d33bf2d8d9ea511f [3]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=b4ee2788a2bd04826626fe022c9a949c7fcf4c2d
Flags: needinfo?(evan)
Assignee | ||
Comment 35•9 years ago
|
||
Nice, all treeherder tasks are passed[1]. Let's land the code. [1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=b4ee2788a2bd04826626fe022c9a949c7fcf4c2d
Assignee | ||
Comment 36•9 years ago
|
||
master: https://github.com/mozilla-b2g/gaia/commit/7103dcfbdbbb2514b735e301f9deb7daf56af23e
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Comment 37•9 years ago
|
||
Strangely if I run the following integration test: TEST_FILES=apps/music/test/marionette/Player_test.js make test-integration It fails on the "Status bar" test which involve the playing indicator in the system tray / status bar.
Comment 38•9 years ago
|
||
And git bisect pointed to that patch.
Comment 39•9 years ago
|
||
Nevermind. It seems that removing the b2g runtime and letting the test suite redownload it eliminated the problem. Also gaia-try is clear with it too. False alarm.
Assignee | ||
Comment 40•9 years ago
|
||
Hubert, no problem.
Updated•9 years ago
|
Target Milestone: --- → FxOS-S5 (21Aug)
Comment 41•9 years ago
|
||
The original bug (using STR at comment 3) has been verified fixed on Flame and Aries. I've also verified the duplicates: bug 1183366, bug 1186338, bug 1186533, bug 1187261, and bug 1195191 are all verified as fixed. Unable to verify the depends on bug 1191207 because I'm not sure how to run the test at bug 1191207 comment 1. I tried and it wanted me to "Get rid of references to gaia-node-modules stuff" and also install something which I'm unsure about. Still setting bug as verified because I think this bug and all the duplicated bugs covered most of the bases for this regression. Verified on: Device: Aries 2.5 BuildID: 20150826051728 Gaia: c1ae9f02f2a9cfb89bf67aeea97e467c41c3362c Gecko: f61c3cc0eb8b7533818e7379ccc063b611015d9d Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd Version: 43.0a1 (2.5) Firmware Version: D5803_23.1.A.1.28_NCB.ftf User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0 Device: Flame 2.5 BuildID: 20150826030209 Gaia: c1ae9f02f2a9cfb89bf67aeea97e467c41c3362c Gecko: f61c3cc0eb8b7533818e7379ccc063b611015d9d Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd Version: 43.0a1 (2.5) Firmware Version: v18Dv4 User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(jmercado)
Keywords: qawanted
Updated•9 years ago
|
Flags: needinfo?(jmercado)
Comment 42•9 years ago
|
||
There is one case we forgot to handle. The issue still can be reproduced. If the we turn off the iframe which have playing audio, we would not send the "audiochannelchanged". STR. 1. Play music from music app 2. Long press home button 3. Swipe off the music app (Turn off) Expected. 4. No playing icon & the volume control type should be "notification" Actual. 4. Have playing icon & the volume control type is "media"
Status: VERIFIED → REOPENED
Flags: needinfo?(evan)
Resolution: FIXED → ---
Assignee | ||
Comment 43•9 years ago
|
||
Alastor, Let's fix the issue(Comment 42) in a new Bug(Bug 1199605). Thanks.
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Flags: needinfo?(evan)
Resolution: --- → FIXED
Updated•9 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•