[promise-dbg] Add a new pane for the promise debugger

RESOLVED FIXED in Firefox 42

Status

()

Firefox
Developer Tools: Inspector
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: gl, Assigned: gl)

Tracking

(Blocks: 2 bugs)

unspecified
Firefox 42
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Updated

2 years ago
Assignee: nobody → gabriel.luong
Status: NEW → ASSIGNED
(Assignee)

Updated

2 years ago
Summary: [promise-dbg] Add a toolbar button for toggling the promise debugger → [promise-dbg] Add a new pane for the promise debugger
(Assignee)

Comment 1

2 years ago
Created attachment 8636341 [details] [diff] [review]
Part 1: Add a new pane for the promise debugger
Attachment #8636341 - Flags: review?(nfitzgerald)
(Assignee)

Comment 2

2 years ago
Created attachment 8636347 [details] [diff] [review]
Part 2: Add a toolbar button for toggling the promise debugger
Attachment #8636347 - Flags: review?(nfitzgerald)
Comment on attachment 8636341 [details] [diff] [review]
Part 1: Add a new pane for the promise debugger

Review of attachment 8636341 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/debugger/debugger-view.js
@@ -599,5 @@
>    /**
>     * Switches the debugger widgets to a horizontal layout.
>     */
>    _enterVerticalLayout: function() {
> -    let normContainer = document.getElementById("debugger-widgets");

This change seems unrelated? Was this unused?

@@ -618,5 @@
>     * Switches the debugger widgets to a vertical layout.
>     */
>    _enterHorizontalLayout: function() {
>      let normContainer = document.getElementById("debugger-widgets");
> -    let vertContainer = document.getElementById("vertical-layout-panes-container");

Was this unused as well?
Attachment #8636341 - Flags: review?(nfitzgerald) → review+
Comment on attachment 8636347 [details] [diff] [review]
Part 2: Add a toolbar button for toggling the promise debugger

Review of attachment 8636347 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/devtools/debugger.inc.css
@@ +120,5 @@
>      list-style-image: url(debugger-pause-uncaught-exceptions@2x.png);
>    }
>  }
> +#toggle-promise-debugger {
> +  /* TODO: Add a toggle promise debugger image */

Add a bug number with the TODO comment.
Attachment #8636347 - Flags: review?(nfitzgerald) → review+
(Assignee)

Comment 5

2 years ago
Comment on attachment 8636341 [details] [diff] [review]
Part 1: Add a new pane for the promise debugger

Review of attachment 8636341 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/debugger/debugger-view.js
@@ -599,5 @@
>    /**
>     * Switches the debugger widgets to a horizontal layout.
>     */
>    _enterVerticalLayout: function() {
> -    let normContainer = document.getElementById("debugger-widgets");

Yes, this change was to remove an unused variable.

@@ -618,5 @@
>     * Switches the debugger widgets to a vertical layout.
>     */
>    _enterHorizontalLayout: function() {
>      let normContainer = document.getElementById("debugger-widgets");
> -    let vertContainer = document.getElementById("vertical-layout-panes-container");

This was also unused.
(Assignee)

Updated

2 years ago
Blocks: 1186119
(Assignee)

Updated

2 years ago
Blocks: 1183863
No longer blocks: 1186119
(Assignee)

Updated

2 years ago
Blocks: 1186119
(Assignee)

Comment 6

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e56860c25e37
(Assignee)

Comment 7

2 years ago
Created attachment 8636708 [details] [diff] [review]
Part 2: Add a toolbar button for toggling the promise debugger
Attachment #8636347 - Attachment is obsolete: true
Attachment #8636708 - Flags: review+

Comment 8

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/53e21aef23f6
https://hg.mozilla.org/integration/fx-team/rev/f51edb65dfa4
https://hg.mozilla.org/mozilla-central/rev/53e21aef23f6
https://hg.mozilla.org/mozilla-central/rev/f51edb65dfa4
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
You need to log in before you can comment on or make changes to this bug.