Closed Bug 1183908 Opened 9 years ago Closed 9 years ago

Put password visibility toggling in the capture doorhanger behind a pref

Categories

(Toolkit :: Password Manager, defect)

defect
Not set
normal
Points:
3

Tracking

()

VERIFIED FIXED
mozilla42
Iteration:
42.3 - Aug 10
Tracking Status
firefox39 --- unaffected
firefox40 --- verified
firefox41 --- verified
firefox42 --- verified

People

(Reporter: MattN, Assigned: MattN)

References

Details

(Whiteboard: pwmgr42)

Attachments

(1 file)

Since we're not sure how users are going to react to this change. Ryan is suggesting that we have a pref for this. This will make it possible to disable this feature in a hotfix if necessary. It can also make it simpler to do user testing.
Flags: firefox-backlog+
Whiteboard: pwmgr42
Iteration: --- → 42.2 - Jul 27
Iteration: 42.2 - Jul 27 → 42.3 - Aug 10
Iteration: 42.3 - Aug 10 → ---
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Iteration: --- → 42.3 - Aug 10
Flags: qe-verify+
Bug 1183908 - Put password visibility toggling in the capture doorhanger behind the pref signon.rememberSignons.visibilityToggle. r=rittme
Attachment #8640908 - Flags: review?(bernardo)
Comment on attachment 8640908 [details]
MozReview Request: Bug 1183908 - Put password visibility toggling in the capture doorhanger behind the pref signon.rememberSignons.visibilityToggle. r=rittme

https://reviewboard.mozilla.org/r/14393/#review13011

Ship It!
Attachment #8640908 - Flags: review?(bernardo) → review+
Comment on attachment 8640908 [details]
MozReview Request: Bug 1183908 - Put password visibility toggling in the capture doorhanger behind the pref signon.rememberSignons.visibilityToggle. r=rittme

Approval Request Comment
[Feature/regressing bug #]: Bug 1169702
[User impact if declined]: Since we're not sure how users are going to react to this change we're putting this behind a pref so users can disable it and so we can disable this feature in a hotfix, if necessary.
[Describe test coverage new/current, TreeHerder]: Manual local test. Kamil can probably verify this tomorrow.
[Risks and why]: Low risk simply not connecting an event handler + emptying a placeholder (Aurora-only)
[String/UUID change made/needed]: None
Attachment #8640908 - Flags: approval-mozilla-beta?
Attachment #8640908 - Flags: approval-mozilla-aurora?
Comment on attachment 8640908 [details]
MozReview Request: Bug 1183908 - Put password visibility toggling in the capture doorhanger behind the pref signon.rememberSignons.visibilityToggle. r=rittme

Approved for Beta and Aurora. For Beta, MattN is going to land this with the pref disabled. (This is a change from what's in the patch.) This feature will be enabled on Aurora.

ni Ryan to ensure that he sees that for Beta this needs to land with the pref set to false.
Flags: needinfo?(ryanvm)
Attachment #8640908 - Flags: approval-mozilla-beta?
Attachment #8640908 - Flags: approval-mozilla-beta+
Attachment #8640908 - Flags: approval-mozilla-aurora?
Attachment #8640908 - Flags: approval-mozilla-aurora+
Matt's going to need to rebase this for uplift to Aurora and Beta anyway.
Flags: needinfo?(ryanvm) → needinfo?(MattN+bmo)
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #9)
> https://hg.mozilla.org/releases/mozilla-aurora/rev/278e3e5284a0

This isn't sufficient, the fx-team patch needed to be used but has conflicts with bug 1186123 which didn't get approved yet.
https://hg.mozilla.org/mozilla-central/rev/7e94e4795386
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Assigning to Kamil for verification in Beta 9. Kamil, if you need help from us just let us know.
QA Contact: kjozwiak
Used the following builds for verification:

- https://ftp.mozilla.org/pub/firefox/nightly/2015-08-04-03-02-04-mozilla-central/
- https://ftp.mozilla.org/pub/firefox/nightly/2015-08-04-00-40-26-mozilla-aurora/
- https://ftp.mozilla.org/pub/firefox/candidates/40.0b9-candidates/build1/

OS's Used:

- OSX 10.10.4 - PASSED
- Windows 8.1 x64 (VM) - PASSED
- Windows 10 x64 - PASSED

Test Cases Used:

* ensured everything is working when visibilityToggle;false under m-c & m-a
** ensured that "Remember", "Not Now", "Don't Remember" are working
* ensured everything is working when visibilityToggle;true under m-b
** ensured that "Remember", "Not Now", "Don't Remember" are working
* ensured that "SHOW" isn't diplayed under the password field when visibilityToggle;false
* ensured you cannot copy the password when visibilityToggle;false (bug # 1191444)

Defaults:

- m-c -> signon.rememberSignons.visibilityToggle;true
- m-a -> signon.rememberSignons.visibilityToggle;true
- m-b -> signon.rememberSignons.visibilityToggle;false
See Also: → 1203294
You need to log in before you can comment on or make changes to this bug.