Closed Bug 1183935 Opened 6 years ago Closed 6 years ago

Review messages sent to bugzilla should show comments in file/line order, not chronological order

Categories

(MozReview Graveyard :: General, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: glandium, Assigned: gps)

Details

Attachments

(1 file)

See https://bugzilla.mozilla.org/show_bug.cgi?id=1181255#c9

::: build/unix/mozconfig.tsan:26
::: build/unix/mozconfig.tsan:11
::: build/unix/mozconfig.tsan:32
::: build/unix/mozconfig.tsan:31
::: browser/config/mozconfigs/linux64/opt-tsan:6
::: build/unix/mozconfig.tsan:18

That's not how it appears on https://reviewboard.mozilla.org/r/13231/#review11895
and can be confusing to read.
Good catch. I'm not sure how comments are sorted today, but I think posting in "file order" makes sense, especially if that's how Review Board renders them itself.
Priority: -- → P3
Here's another example of the order being fairly confusing:

Correct order = https://reviewboard.mozilla.org/r/14661/#review13289
Wrong order = https://bugzilla.mozilla.org/show_bug.cgi?id=1141352#c11
(In reply to François Marier [:francois] from comment #2)
> Here's another example of the order being fairly confusing:
> 
> Correct order = https://reviewboard.mozilla.org/r/14661/#review13289
> Wrong order = https://bugzilla.mozilla.org/show_bug.cgi?id=1141352#c11

What's notable here is that the order isn't even chronological. Given that one comment references to the other that would defeat causality :-)
rbbz: sort comments by file and line number (bug 1183935); r?smacleod

This is how Review Board itself does it (see
reviewboard.reviews.views.preview_reply_email).

I didn't write a test because it is a Monday.
Attachment #8645838 - Flags: review?(smacleod)
Comment on attachment 8645838 [details]
MozReview Request: rbbz: sort comments by file and line number (bug 1183935); r?smacleod

https://reviewboard.mozilla.org/r/15555/#review13975

Just tested it out locally and works for me!
Attachment #8645838 - Flags: review+
Attachment #8645838 - Flags: review?(smacleod) → review+
Comment on attachment 8645838 [details]
MozReview Request: rbbz: sort comments by file and line number (bug 1183935); r?smacleod

https://reviewboard.mozilla.org/r/15555/#review14007

Ship It!
url:        https://hg.mozilla.org/hgcustom/version-control-tools/rev/4b8550503d1801b540ffa8567535626aa0bb99c5
changeset:  4b8550503d1801b540ffa8567535626aa0bb99c5
user:       Gregory Szorc <gps@mozilla.com>
date:       Tue Aug 11 10:37:50 2015 -0700
description:
rbbz: sort comments by file and line number (bug 1183935); r=smacleod

This is how Review Board itself does it (see
reviewboard.reviews.views.preview_reply_email).

I didn't write a test because it is a Monday.
Not sure when this will be deployed. I'll try to remember to update the bug when it is.
Assignee: nobody → gps
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.