1183935 - Review messages sent to bugzilla should show comments in file/line order, not chronological order

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect, P3)

Description

[Mike Hommey [:glandium]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1181255#c9

::: build/unix/mozconfig.tsan:26
::: build/unix/mozconfig.tsan:11
::: build/unix/mozconfig.tsan:32
::: build/unix/mozconfig.tsan:31
::: browser/config/mozconfigs/linux64/opt-tsan:6
::: build/unix/mozconfig.tsan:18

That's not how it appears on https://reviewboard.mozilla.org/r/13231/#review11895
and can be confusing to read.

Comment 1

[Gregory Szorc [:gps]]

Good catch. I'm not sure how comments are sorted today, but I think posting in "file order" makes sense, especially if that's how Review Board renders them itself.

Comment 2

[François Marier [:francois]]

Here's another example of the order being fairly confusing:

Correct order = https://reviewboard.mozilla.org/r/14661/#review13289
Wrong order = https://bugzilla.mozilla.org/show_bug.cgi?id=1141352#c11

Comment 3

[Gian-Carlo Pascutto [:gcp]]

(In reply to François Marier [:francois] from comment #2)
> Here's another example of the order being fairly confusing:
> 
> Correct order = https://reviewboard.mozilla.org/r/14661/#review13289
> Wrong order = https://bugzilla.mozilla.org/show_bug.cgi?id=1141352#c11

What's notable here is that the order isn't even chronological. Given that one comment references to the other that would defeat causality :-)

Comment 4

[Gregory Szorc [:gps]]

Attachment: MozReview Request: rbbz: sort comments by file and line number (bug 1183935); r?smacleod

rbbz: sort comments by file and line number (bug 1183935); r?smacleod

This is how Review Board itself does it (see
reviewboard.reviews.views.preview_reply_email).

I didn't write a test because it is a Monday.

Comment 5

[Mark Côté [:mcote]]

Comment on attachment 8645838 [details]
MozReview Request: rbbz: sort comments by file and line number (bug 1183935); r?smacleod

https://reviewboard.mozilla.org/r/15555/#review13975

Just tested it out locally and works for me!

Comment 6

[Steven MacLeod [:smacleod]]

Comment on attachment 8645838 [details]
MozReview Request: rbbz: sort comments by file and line number (bug 1183935); r?smacleod

https://reviewboard.mozilla.org/r/15555/#review14007

Ship It!

Comment 7

[Gregory Szorc [:gps]]

url:        https://hg.mozilla.org/hgcustom/version-control-tools/rev/4b8550503d1801b540ffa8567535626aa0bb99c5
changeset:  4b8550503d1801b540ffa8567535626aa0bb99c5
user:       Gregory Szorc <[e-mail]>
date:       Tue Aug 11 10:37:50 2015 -0700
description:
rbbz: sort comments by file and line number (bug 1183935); r=smacleod

This is how Review Board itself does it (see
reviewboard.reviews.views.preview_reply_email).

I didn't write a test because it is a Monday.

Comment 8

[Gregory Szorc [:gps]]

Not sure when this will be deployed. I'll try to remember to update the bug when it is.