1184045 - Enable region specific search defaults

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Florian Quèze [:florian]]

The code for this landed in bug 1175218, but I had to disable it by emptying the browser.search.geoSpecificDefaults.url prefs due to Talos and Crashtest bustages.

Comment 1

[Florian Quèze [:florian]]

Attachment: Talos - set geoSpecificDefaults to false

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8634002 [details] [diff] [review]
Talos - set geoSpecificDefaults to false

Review of attachment 8634002 [details] [diff] [review]:
-----------------------------------------------------------------

will this need to be the case for android tests as well?  we have a different framework we are standing up called autophone.  It currently does a lot, but we are moving the android tests there.  If this is for android right now, then we need to generate a new talos.zip, I can do that and test it if needed.

Please land this on the talos repository and I can take it from there.

p.s. do we have this set for mochitest, reftest, marionette?

Comment 3

[Florian Quèze [:florian]]

Attachment: Re-enable geo specific defaults

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca355f148960

Comment 4

[Florian Quèze [:florian]]

(In reply to Joel Maher (:jmaher) from comment #2)

Thanks for the review!

> will this need to be the case for android tests as well?  we have a
> different framework we are standing up called autophone.

autophone is being handled in bug 1182802.

> p.s. do we have this set for mochitest, reftest, marionette?

mochitest and xpcshell tests were handled in my initial patch.

The patch I just attached here takes care of reftests.

Do I need to do something for marionette?

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

we might need to do something for marionette, I have cc'd chmanchester who can help get us closer to an answer.  sounds like we are close.

Comment 6

[Chris Manchester (limited bugmail, email directly)]

Marionette looks fine in the try run in comment 3. If you end up needing to set default prefs for it, they're at the top of https://dxr.mozilla.org/mozilla-central/source/testing/marionette/driver/marionette_driver/geckoinstance.py

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/b17114dbb66c

Comment 8

[Florian Quèze [:florian]]

Comment on attachment 8634002 [details] [diff] [review]
Talos - set geoSpecificDefaults to false

https://hg.mozilla.org/build/talos/rev/8a61f8d21fc0

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/2443bc31946a

Comment 10

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/fx-team/rev/219c031a0631

Comment 11

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/b17114dbb66c

Comment 12

[Nazir Ahmed Sabbir [:NaSb]]

I have successfully reproduced the bug in Nightly 42.0a1 (2015-07-15) (Build ID: 20150715095506) on Linux x64.

Bug is now fixed on Latest Nightly 42.0a1 (2015-07-21)

Build ID: 20150721030212
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:42.0) Gecko/20100101 Firefox/42.0

Comment 13

[Hossain Al Ikram [:ikram] (QA Contact)]

I have seen the bug on windows 7, 64 bit  with Nightly 42.0a1 (2015-07-15)!

This Bugs fix is verified now on Latest 42.0a1 (2015-07-21)

Build ID : 20150721030212
User Agent : Mozilla/5.0 (Windows NT 6.1; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0
As it is also verified on Linux, too (Comment 12), Marking it as verified!