Enable region specific search defaults

VERIFIED FIXED in Firefox 42

Status

()

VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: florian, Assigned: florian)

Tracking

Trunk
Firefox 42
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 verified)

Details

(Whiteboard: [bugday-20150722])

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
The code for this landed in bug 1175218, but I had to disable it by emptying the browser.search.geoSpecificDefaults.url prefs due to Talos and Crashtest bustages.
(Assignee)

Comment 1

3 years ago
Created attachment 8634002 [details] [diff] [review]
Talos - set geoSpecificDefaults to false
Attachment #8634002 - Flags: review?(jmaher)
Comment on attachment 8634002 [details] [diff] [review]
Talos - set geoSpecificDefaults to false

Review of attachment 8634002 [details] [diff] [review]:
-----------------------------------------------------------------

will this need to be the case for android tests as well?  we have a different framework we are standing up called autophone.  It currently does a lot, but we are moving the android tests there.  If this is for android right now, then we need to generate a new talos.zip, I can do that and test it if needed.

Please land this on the talos repository and I can take it from there.

p.s. do we have this set for mochitest, reftest, marionette?
Attachment #8634002 - Flags: review?(jmaher) → review+
(Assignee)

Comment 4

3 years ago
(In reply to Joel Maher (:jmaher) from comment #2)

Thanks for the review!

> will this need to be the case for android tests as well?  we have a
> different framework we are standing up called autophone.

autophone is being handled in bug 1182802.

> p.s. do we have this set for mochitest, reftest, marionette?

mochitest and xpcshell tests were handled in my initial patch.

The patch I just attached here takes care of reftests.

Do I need to do something for marionette?
we might need to do something for marionette, I have cc'd chmanchester who can help get us closer to an answer.  sounds like we are close.
Marionette looks fine in the try run in comment 3. If you end up needing to set default prefs for it, they're at the top of https://dxr.mozilla.org/mozilla-central/source/testing/marionette/driver/marionette_driver/geckoinstance.py
(Assignee)

Comment 8

3 years ago
Comment on attachment 8634002 [details] [diff] [review]
Talos - set geoSpecificDefaults to false

https://hg.mozilla.org/build/talos/rev/8a61f8d21fc0
https://hg.mozilla.org/mozilla-central/rev/b17114dbb66c
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
I have successfully reproduced the bug in Nightly 42.0a1 (2015-07-15) (Build ID: 20150715095506) on Linux x64.

Bug is now fixed on Latest Nightly 42.0a1 (2015-07-21)

Build ID: 20150721030212
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:42.0) Gecko/20100101 Firefox/42.0
QA Whiteboard: [bugday-20150722]
Whiteboard: [bugday-20150722]
I have seen the bug on windows 7, 64 bit  with Nightly 42.0a1 (2015-07-15)!

This Bugs fix is verified now on Latest 42.0a1 (2015-07-21)

Build ID : 20150721030212
User Agent : Mozilla/5.0 (Windows NT 6.1; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0
As it is also verified on Linux, too (Comment 12), Marking it as verified!
Status: RESOLVED → VERIFIED
status-firefox42: fixed → verified
You need to log in before you can comment on or make changes to this bug.