1184058 - AudioChannelAgent should be muted when used without a proper window object.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrea Marchesini [:baku]]

Currently we have some AudioChannelAgents initialized with a null window.
These should be muted by default or crash.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: detect.patch

This patch will help to detect where we have AudioChannelAgents with a null window.

Comment 2

[Alastor Wu [:alwu]]

Comment on attachment 8634022 [details] [diff] [review]
detect.patch

Review of attachment 8634022 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, Thanks!

Comment 3

[Andrea Marchesini [:baku]]

Alwu, any news to remove the AudioChannelAgent with null window in telephony and AudioManager?

Comment 4

[Alastor Wu [:alwu]]

Before landing this issue, we should remove the null window telephony/ringtone agent in AudioManage.cpp.

(1) Remove telephony agent - bug1129882
We only need to wait for the this bug, and it should be landed after your review :)

But if we want to manage the telephony correctly, it will be done after bug1185442.

(2) Remove ringtone agent - bug1185442
Now I am waiting for the feedback from Gabriele. We plan to playback a silent ringtone when there is incoming call during the vibration mode. 

If we can do it in Gaia, I can remove the codes in Gecko.

Comment 5

[Alastor Wu [:alwu]]

Sorry, correct the comment4.
Removing ringtone agent would be implemented in this bug, bug1184482.

Comment 6

[Andrea Marchesini [:baku]]

alwu, can we land this patch?

Comment 7

[Alastor Wu [:alwu]]

Yes :)

Comment 8

[Alastor Wu [:alwu]]

Hi, Baku,
Maybe we still need to postpone landing this issue, see bug1193840 comment7.

Comment 9

[Andrea Marchesini [:baku]]

ok. Can you set a dependence so that when that is landed we can land this patch too? Thanks.

Comment 10

[Andrea Marchesini [:baku]]

Shall we try to land the patch?

Comment 11

[Alastor Wu [:alwu]]

Ok, all null agents have been removed.
Although the bug1129882 is opened again, I think it doesn't affect this bug. 
Sorry for the delay.

Comment 12

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0708602ea554dddb31bdbf172596fc2e29ca832e
Bug 1184058 - AudioChannelAgent should be muted when used without a proper window object, r=alwu

Comment 13

[Nigel Babu [:nigelb]]

This patch has d2 bustages like this https://treeherder.mozilla.org/logviewer.html#?job_id=13360819&repo=mozilla-inbound. Going to back it out.

Comment 14

[Nigel Babu [:nigelb]]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/f4f537fe2647

Comment 15

[Andrea Marchesini [:baku]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=65f828feb692

Comment 16

[Andrea Marchesini [:baku]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=083c40084730

Comment 17

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ddc08e87843f8578adb0ba42887f66044358d563
Bug 1184058 - AudioChannelAgent should be muted when used without a proper window object, r=alwu

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Backed out for AudioChannelAgent crashes/asserts.
https://treeherder.mozilla.org/logviewer.html#?job_id=13554814&repo=mozilla-inbound
https://treeherder.mozilla.org/logviewer.html#?job_id=13556810&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/499f911151a0

Comment 19

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7cf7a64736ee

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7cf7a64736ee