[NGA][Contacts] VCARD loader as independent page

RESOLVED FIXED in Firefox OS master

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: fcampo, Assigned: mancas)

Tracking

unspecified
FxOS-S5 (21Aug)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(b2g-master fixed)

Details

(Whiteboard: [NG Gaia Contacts][patch])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
we need to load the vcards information and show it to the user without going through all the critical path for contacts, so we're able to open it directly from the corresponding activities.

Following the NGA approach, split logic and UX should be done.
(Reporter)

Updated

3 years ago
Blocks: 1184070
Whiteboard: [NG Gaia Contacts]
Target Milestone: --- → FxOS-S3 (24Jul)
Target Milestone: FxOS-S3 (24Jul) → FxOS-S4 (07Aug)
Created attachment 8641542 [details] [review]
[gaia] mancas:import > mozilla-b2g:master
Whiteboard: [NG Gaia Contacts] → [NG Gaia Contacts][patch]
Assignee: nobody → b.mcb
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 years ago
Comment on attachment 8641542 [details] [review]
[gaia] mancas:import > mozilla-b2g:master

Hey Borja, can you take a look at the patch?
Attachment #8641542 - Flags: feedback?(borja.bugzilla)
Attachment #8641542 - Flags: feedback?(borja.bugzilla) → review?(fernando.campo)
(Reporter)

Comment 3

3 years ago
Comment on attachment 8641542 [details] [review]
[gaia] mancas:import > mozilla-b2g:master

a few nits for code style, but works good on phone. great work Manu!!
Attachment #8641542 - Flags: review?(fernando.campo) → review+
Comment on attachment 8641542 [details] [review]
[gaia] mancas:import > mozilla-b2g:master

LGTM as well. Just fix Fernando's suggestions and we are done! :)
Attachment #8641542 - Flags: review+
Target Milestone: FxOS-S4 (07Aug) → FxOS-S5 (21Aug)
(Assignee)

Comment 5

3 years ago
Landed in master: https://github.com/mozilla-b2g/gaia/commit/ed4586d6e6b24010b26484b32b372f8c7bcf63e7
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
status-b2g-master: --- → fixed
You need to log in before you can comment on or make changes to this bug.