Closed
Bug 1184077
Opened 10 years ago
Closed 10 years ago
[NGA][Contacts] VCARD loader as independent page
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(b2g-master fixed)
RESOLVED
FIXED
FxOS-S5 (21Aug)
| Tracking | Status | |
|---|---|---|
| b2g-master | --- | fixed |
People
(Reporter: fcampo, Assigned: mancas)
References
Details
(Whiteboard: [NG Gaia Contacts][patch])
Attachments
(1 file)
we need to load the vcards information and show it to the user without going through all the critical path for contacts, so we're able to open it directly from the corresponding activities.
Following the NGA approach, split logic and UX should be done.
|
||
Updated•10 years ago
|
Whiteboard: [NG Gaia Contacts]
Target Milestone: --- → FxOS-S3 (24Jul)
|
|
||
Updated•10 years ago
|
Target Milestone: FxOS-S3 (24Jul) → FxOS-S4 (07Aug)
|
||
Comment 1•10 years ago
|
||
|
|
||
Updated•10 years ago
|
Whiteboard: [NG Gaia Contacts] → [NG Gaia Contacts][patch]
|
|
||
Updated•10 years ago
|
Assignee: nobody → b.mcb
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8641542 [details] [review]
[gaia] mancas:import > mozilla-b2g:master
Hey Borja, can you take a look at the patch?
Attachment #8641542 -
Flags: feedback?(borja.bugzilla)
|
|
||
Updated•10 years ago
|
Attachment #8641542 -
Flags: feedback?(borja.bugzilla) → review?(fernando.campo)
|
Reporter | |
Comment 3•10 years ago
|
||
Comment on attachment 8641542 [details] [review]
[gaia] mancas:import > mozilla-b2g:master
a few nits for code style, but works good on phone. great work Manu!!
Attachment #8641542 -
Flags: review?(fernando.campo) → review+
|
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8641542 [details] [review]
[gaia] mancas:import > mozilla-b2g:master
LGTM as well. Just fix Fernando's suggestions and we are done! :)
Attachment #8641542 -
Flags: review+
|
|
||
Updated•10 years ago
|
Target Milestone: FxOS-S4 (07Aug) → FxOS-S5 (21Aug)
|
|
Assignee | |
Comment 5•10 years ago
|
||
Landed in master: https://github.com/mozilla-b2g/gaia/commit/ed4586d6e6b24010b26484b32b372f8c7bcf63e7
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
||
Updated•10 years ago
|
status-b2g-master:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•