1184101 - report/index modules tab should link to symbol file on s3 for modules with loaded symbols

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[(not currently active) Ted Mielczarek]

I occasionally find myself needing to spot check symbol files. It'd be nice if the Modules tab of report/index would link to the symbol file for modules with loaded symbols now that they're on S3.

We might need to make the stackwalker put the relative symbol file URL in the modules list, since otherwise you'd have to duplicate that logic. We'd also probably need a base URL in the config, unless we can re-use the config from the symbol upload API.

Comment 1

[Peter Bengtsson [:peterbe]]

"symbol files"?

We have text of every uploaded file in every upload .zip in the database. Do you mean we'd get something like "/symbolPush/4FD6B6CD4FB645339FB0BC98E5790A0E1/NPSWF64.pdb" from the stackwalker and use that, in the report/index, to figure out that it came from symbolPush_win_18.0.0.209.zip?

With all the bombardment from the releng API we have amassed quite a few of these text records. It might make for a relatively expensive search through the database. 

If we could have a string like symbolPush_win_18.0.0.209.zip? in the stackwalker stuff I could a lot more easily find a reference to the uploaded symbols file and make a link to it. (...using the relevant right permissions).

Comment 2

[(not currently active) Ted Mielczarek]

No, the stackwalker just looks up symbol files by using <module name>/<guid>/<module name>.sym, so for example in https://crash-stats.mozilla.com/report/index/9671b54d-925c-4e20-9dc7-d95fb2150526 the symbol file for firefox.exe is firefox.pdb/995A0A50EA284DB1A41A9A3091BC700A2/firefox.sym, and I'd just want a link to https://s3-us-west-2.amazonaws.com/org.mozilla.crash-stats.symbols-public/v1/firefox.pdb/995A0A50EA284DB1A41A9A3091BC700A2/firefox.sym . The stackwalker has already calculated that to load the symbol file, so it wouldn't be hard to put it in the JSON output.

Comment 3

[Peter Bengtsson [:peterbe]]

So this is a Lars bug? Lars? Maketh sense?

Comment 4

[(not currently active) Ted Mielczarek]

I think I need a separate bug to make the stackwalker expose symbol file paths in the JSON output, then this would be a simple frontend UI bug.

Comment 5

[(not currently active) Ted Mielczarek]

My patch in bug 1187852 just exposes a `symbol_url` key for entries in the `modules` list where we loaded symbols, so once that lands fixing this should be as simple as generating a link with that href when that key is present.

Comment 6

[(not currently active) Ted Mielczarek]

That landed, so if you look at recent crash reports, like:
https://crash-stats.mozilla.com/report/index/e01c9a77-8a09-43b5-bc84-3deb52160503

You can see in the modules list (from the raw dump tab):
```
 { "base_addr": "0x100000000", "code_id": "id", "debug_file": "plugin-container", "debug_id": "FCAB48A3645B39A7A2F94A5D952CA0270", "end_addr": "0x10000a000", "filename": "plugin-container", "loaded_symbols": true, "symbol_disk_cache_hit": true, "symbol_url": "https://s3-us-west-2.amazonaws.com/org.mozilla.crash-stats.symbols-public/v1/plugin-container/FCAB48A3645B39A7A2F94A5D952CA0270/plugin-container.sym", "version": "" },
```

So fixing this should be as simple as making some part of the row in the modules tab into a link to `symbols_url` if that key exists.

Comment 7

[(not currently active) Ted Mielczarek]

Typo: `symbol_url`.

Comment 8

[Peter Bengtsson [:peterbe]]

Attachment: Link to Github pull-request: https://github.com/mozilla/socorro/pull/3351

Comment 9

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/986be36f7a9464f1ce837b5fe04ea4c10cb5b864
fixes bug 1184101 - report index modules tab link to symbols (#3351)

r=adngdb