1184121 - Better ui around the treeherder integration

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect, P1)

Description

[Mauro Doglio [:mdoglio]]

The current integration with autoland/treeherder creates a new changedesc panel everytime you trigger autoland to try. This behaviour has 2 problems:
1- The updates from treeherder are not easily spottable, specially when you have tens of changedesc panels.
2- The fact that the latest changedesc is at the bottom can lead you to look at an obsolete push status report.

We should render the autoland/treeherder status close to the `try autoland` button in the main review request panel and only show the latest autoland event/push autolanded

Comment 1

[Mauro Doglio [:mdoglio]]

Attachment: MozReview Request: mozreview: add autoland results panel (Bug 1184121) r?smacleod

mozreview: add autoland results panel (Bug 1184121) r?smacleod

Comment 2

[Steven MacLeod [:smacleod]]

Comment on attachment 8660638 [details]
MozReview Request: mozreview: add autoland results panel (Bug 1184121) r?smacleod

https://reviewboard.mozilla.org/r/19155/#review17047

::: pylib/mozreview/mozreview/fields.py:91
(Diff revision 1)
> +            'autoland_request': autoland_request

I think this should be something like "latest_autoland_request"

::: pylib/mozreview/mozreview/static/mozreview/css/commits.less:197
(Diff revision 1)
> +#ci-actions {

Can you add some screenshots of the different states and how it all appears in page, I'd like to give it a visual review.

::: pylib/mozreview/mozreview/static/mozreview/css/commits.less:227
(Diff revision 1)
> +                background-color: #B0EFA0;

I wonder if it'd be worth sticking some of these colours in variables so we can reuse them elsewhere?

Comment 3

[Mauro Doglio [:mdoglio]]

Comment on attachment 8660638 [details]
MozReview Request: mozreview: add autoland results panel (Bug 1184121) r?smacleod

mozreview: add autoland results panel (Bug 1184121) r?smacleod

Comment 4

[Mauro Doglio [:mdoglio]]

Comment on attachment 8660638 [details]
MozReview Request: mozreview: add autoland results panel (Bug 1184121) r?smacleod

mozreview: add autoland results panel (Bug 1184121) r?smacleod

Comment 5

[Mauro Doglio [:mdoglio]]

https://reviewboard.mozilla.org/r/19155/#review17047

> I wonder if it'd be worth sticking some of these colours in variables so we can reuse them elsewhere?

We could do that the first time we need to reuse those colors.

Comment 6

[Steven MacLeod [:smacleod]]

Comment on attachment 8660638 [details]
MozReview Request: mozreview: add autoland results panel (Bug 1184121) r?smacleod

https://reviewboard.mozilla.org/r/19155/#review18567

::: pylib/mozreview/mozreview/fields.py:91
(Diff revision 3)
> +            'latest_autoland_request': latest_autoland_request

trailing comma please

::: pylib/mozreview/mozreview/static/mozreview/js/commits.js:261
(Diff revision 3)
> +    var repository =$(elem).data('repository');

space after `=`

Comment 7

[Mauro Doglio [:mdoglio]]

Comment on attachment 8660638 [details]
MozReview Request: mozreview: add autoland results panel (Bug 1184121) r?smacleod

mozreview: add autoland results panel (Bug 1184121) r?smacleod

Comment 8

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

https://reviewboard.mozilla.org/r/19155/#review18709

::: pylib/mozreview/mozreview/templates/mozreview/commits.html:109
(Diff revision 4)
> +          <a href="https://treeherder.mozilla.org/embed/resultset-status/try/{{latest_autoland_request.repository_revision}}/">

This panel is great! How about change this link to the real treeherder link instead of the embedded one to save us one extra click to the treeherder?

Comment 9

[Mauro Doglio [:mdoglio]]

:TYLin I filed bug 1211463 to address it