Closed Bug 1184164 Opened 11 years ago Closed 11 years ago

[Accessibility] Enable additional automated accessibility testing for gaia-components.

Categories

(Firefox OS Graveyard :: Gaia::Components, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Components
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: yzen, Assigned: yzen)

Details

(Keywords: access)

Attachments

(1 file, 3 obsolete files)

Github pull request (new test utils).
54 bytes, text/x-github-pull-request
wilsonpage
: review+
Details | Review
There are several tools that could help us get some automated a11y testing done when working on gaia-components. I'm currently looking at several of them, axe-core, a11y, etc and will come up with some suggestions here.
Attached file Github pull request. (obsolete) —
Note that axe dependency is incorrect here, I need to update to a newest version of the module as soon as my contributions there are included in the version bump.
Attachment #8634148 - Flags: feedback?(wilsonpage)
Attachment #8634148 - Flags: feedback?(gasolin)
This is a working example of running marionette integration against a web-component. This is the only true way at the moment to verify if something is actually accessible and actionable as well as to verify if something has the right state (visibility, disabled, etc) from both user and accessibility perspective.
Attachment #8634360 - Flags: feedback?(wilsonpage)
Attachment #8634360 - Flags: feedback?(gasolin)
Comment on attachment 8634360 [details] [review] Integration testing Github pull request. This is great, thanks for working on this! I see some failures on Travis, why is this? Also some NITs inline :)
Attachment #8634360 - Flags: feedback?(wilsonpage) → feedback+
Comment on attachment 8634360 [details] [review] Integration testing Github pull request. Looks great! If Accessibility is a reusable utility, maybe we could put it in gaia-component or elsewhere.
Attachment #8634360 - Flags: feedback?(gasolin) → feedback+
(In reply to Fred Lin [:gasolin] from comment #4) > Comment on attachment 8634360 [details] [review] > Integration testing Github pull request. > > Looks great! If Accessibility is a reusable utility, maybe we could put it > in gaia-component or elsewhere. It could be part of an external gaia-components/test-utils package that could include common test related code.
Comment on attachment 8634148 [details] [review] Github pull request. Why do we have to run Accessiblity.check() in every test. Can't we have a dedicated test suite that checks accessibility stuff?
Attachment #8634148 - Flags: feedback?(wilsonpage)
Comment on attachment 8634148 [details] [review] Github pull request. As Wilson said, It's a bit strange to call accessiblity.check() in every test
Attachment #8634148 - Flags: feedback?(gasolin)
Attached file gaia-component a11y test utils PR (obsolete) —
Attachment #8640701 - Flags: review?(gasolin)
Comment on attachment 8640701 [details] [review] gaia-component a11y test utils PR Looks good to me, but I don't have the org permission so it's better to ask Wilson for review.
Attachment #8640701 - Flags: review?(gasolin) → feedback+
Attachment #8640701 - Attachment is obsolete: true
Comment on attachment 8634148 [details] [review] Github pull request. This should be using gaia-components/test-utils now
Attachment #8634148 - Flags: review?(wilsonpage)
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment on attachment 8634360 [details] [review] Integration testing Github pull request. This should be in order now.
Attachment #8634360 - Flags: review?(wilsonpage)
Just reopening for now to land integration testing.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Hey Wilson, would you have a moment to take a look at the integration tests PR, if it looks good I'll start looking at other gaia-components.
Flags: needinfo?(wilsonpage)
Comment on attachment 8634360 [details] [review] Integration testing Github pull request. Love it! Couple of NITs, but let's ship it after :)
Flags: needinfo?(wilsonpage)
Attachment #8634360 - Flags: review?(wilsonpage) → review+
Closing this one as all checks are now in place in gaia-switch. Will open component specifics bugs from now on.
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Attachment #8634148 - Attachment is obsolete: true
Attachment #8634360 - Attachment is obsolete: true
Attachment #8655587 - Flags: review?(wilsonpage)
Reopening to update test-utils.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: