1184180 - Add support to toggle display "shade"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Accessibility, defect)

Description

[Eitan Isaacson [:eeejay]]

Screen reader users should enjoy the fact that they don't need the screen to be physically on during normal operation. This conserves battery and provides privacy against people looking over the user's shoulder.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] eeejay:bug-1184180 > mozilla-b2g:master

Comment 2

[Eitan Isaacson [:eeejay]]

Comment on attachment 8635431 [details] [review]
[gaia] eeejay:bug-1184180 > mozilla-b2g:master

This keeps most of the logic in the accessibility module and adds a new state in the screen manager that overrides the users brightness and forces it to 0 when the shade is toggled.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8635431 [details] [review]
[gaia] eeejay:bug-1184180 > mozilla-b2g:master

I don't think ScreenManager is in good shape to pile feature on -- it's unit tests are probably never cover everything in full, but, if you are adventurous I won't stop you on that -- just to make sure you leave a lot of time for possible regressions.

Comment 4

[Eitan Isaacson [:eeejay]]

I'll take the chance. Better regressions sooner than later!

Comment 5

[Eitan Isaacson [:eeejay]]

https://github.com/mozilla-b2g/gaia/commit/8502d07cd7e68da79303471acf64eea48b3dce24

Comment 6

[jomyounghoon]

Could you upload this patch to v2.2r?

Comment 7

[Eitan Isaacson [:eeejay]]

I would like to. There is a set of patches. What is the landing procedure for v2.2r. Who do I ask for approval?

Comment 8

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

At the current stage there's no approval flag needed to uplift to 2.2R.
I just set the checkin-needed and feature-b2g:2.2r+ so that releng will follow up.
Please refer to [1].

[1] https://wiki.mozilla.org/Release_Management/FirefoxOS/2_2_R_Schedule#Patch_Uplifts

Comment 9

[Carsten Book [:Tomcat]]

(In reply to Eitan Isaacson [:eeejay] from comment #7)
> I would like to. There is a set of patches. What is the landing procedure
> for v2.2r. Who do I ask for approval?

Hey Eeejay could you provide a PR request and i will get this into 2.2r 

Thanks!

Comment 10

[GitHub Autolander Bot]

Attachment: [gaia] eeejay:bug-1184180-v22r > mozilla-b2g:v2.2r

Comment 11

[Eitan Isaacson [:eeejay]]

Thanks, Tomcat!

Comment 12

[Eitan Isaacson [:eeejay]]

Rebased and tested.

Comment 13

[Carsten Book [:Tomcat]]

for 2.2r -> https://github.com/mozilla-b2g/gaia/commit/f353fd99859c69eaad1dcb6cba09f38675934046

thanks eitan!

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

We can drop checkin-needed, now, right?

Comment 15

[Eitan Isaacson [:eeejay]]

Yes.