1184210 - [Status Bar] 'Pin the Web' icon doesn't always mirror app icon, shows pin graphic

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Oliver Nelson [:oliverthor]]

Attachment: pin_icon_not_mirroring_app.png

Description:
When a user enters an application, they may observe that the 'pin the web' icon on the search bar will now mimic the icon of the current application and list the name of the app in the search. However, the user may observe upon entering certain apps, first open or waking from card view, that the app icon will display the pin graphic again instead of the app.
Looks like this bug created the functionality: bug 1181602
Issue is commonly reproducing in clock and calendar apps, and not within communication apps (dialer, messages, contacts). Though, actual behavior has also been seen within clock as well.

Repro Steps:
1) Update a Flame to 20150715010202
2) Open the Clock app
3) Observe the "Search the Web" bar of the status bar: displays "Clock"
4) Observe the 'pin the web' icon

Actual:
'pin the web' icon displays pin graphic

Expected:
'pin the web' icon mirrors open app icon


Environmental Variables:
-------------------------

Device: Aries 2.5
BuildID: 20150715083340
Gaia: c6ef08964711f461a8e6326eae911789d1ec220c
Gecko: c95ebeebbc5d
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Device: Flame 2.5
Build ID: 20150715010202
Gaia: c6ef08964711f461a8e6326eae911789d1ec220c
Gecko: c95ebeebbc5d
Gonk: a4f6f31d1fe213ac935ca8ede7d05e47324101a4
Version: 42.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0
************************

Issue is not present on 2.2 for flame devices
Results: No 'pin the web' icons in status bar

Device: Flame 2.2
BuildID: 20150715002506
Gaia: 84d0c76370dcd3d25813b00de55194730884355b
Gecko: a5db6d9850f6
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
-------------------------


Repro frequency: 3/5
See attached: 
screenshot
logcat [dialer, messages, contacts: expected  |  clock, calendar: actual]

Comment 1

[Oliver Nelson [:oliverthor]]

Attachment: logcat_20150715_0959.txt

Comment 3

[Alberto Pastor [:albertopq]]

I don't think this is a duplicate of bug 1181185. I think there is a race condition somewhere, so sometimes is showing the right icon and sometimes is not.

I'll take a look.

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1184210-icon-race-cond > mozilla-b2g:master

Comment 5

[Ben Francis [:benfrancis]]

Comment on attachment 8634612 [details] [review]
[gaia] albertopq:1184210-icon-race-cond > mozilla-b2g:master

Thanks Alberto!

Comment 6

[Ben Francis [:benfrancis]]

https://github.com/mozilla-b2g/gaia/commit/5f3cfc662bac683438ddd260f4bbd1f55b3b5b9b

Comment 8

[Martin Shuman [:Marty]]

This issue is verified fixed on the latest Spark and Flame 2.5 builds.
All default system apps properly display their app icon in the status bar for 'pin the web'

Environmental Variables:
Device: Aries 2.5
BuildID: 20150827170205
Gaia: d784c81961d82cbe9e111405468c590a8345856c
Gecko: ca086f9ef8bca2d6cdfa79bfc4c854f56a59859e
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Environmental Variables:
Device: Flame 2.5
BuildID: 20150827083151
Gaia: d784c81961d82cbe9e111405468c590a8345856c
Gecko: b33eae31bd7188024b54228e0c0345800a65e595
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 43.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0