1184223 - Migrate FM Radio to l20n.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::FMRadio, defect)

Description

[Staś Małolepszy :stas]

shared/js/l20n.js is the successor of l10n.js with a more robust language fallback and a new architecture which was designed with NGA in mind.

We'd like FM Radio to be the first Gaia app to migrate to l20n.js.

I'll attach a PR shortly.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] stasm:1184223-fm-l20n > mozilla-b2g:master

Comment 2

[Staś Małolepszy :stas]

Comment on attachment 8634223 [details] [review]
[gaia] stasm:1184223-fm-l20n > mozilla-b2g:master

Tim, can you take a look at this?

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8634223 [details] [review]
[gaia] stasm:1184223-fm-l20n > mozilla-b2g:master

I've been doing intensive performance/memory tests on FM as our first target for the transition.

The current numbers look great with no regressions on Z3 and Flame and good potential for further optimizations. On top of that, because l20n.js is way more asynchronous and written in es6 we should benefit from multi-core architecture and spidermonkey optimizations for es6.

Memory wise, we see a minor hit within 80kb. Most of that comes from the fact that l20n.js is modular while l10n.js is "flat". I believe it's a good trade-off for much better modularity and more asynchronous code base.
I'm still working on memory optimizations and I hope to win that 80kb back, but at the moment, I'd recommend moving forward with what we have here.

Comment 4

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/30988

Autolander could not land the pull request due to not having collaborator rights. This is possibly due to a tree closure. Please check the tree status and request checkin again once the tree is open.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/94f2f2f09bbbf63e019f164de9cb014e3cb120b3