Closed Bug 1184242 Opened 4 years ago Closed 4 years ago

1,900 instances of "'aTabParent != sActiveTabParent'" emitted from dom/events/IMEStateManager.cpp during linux64 debug testing

Categories

(Core :: DOM: Events, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

> 1913 [NNNNN] WARNING: 'aTabParent != sActiveTabParent', file dom/events/IMEStateManager.cpp, line 948

This warning [1] shows up in the following test suites:

> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-3-bm118-tests1-linux64-build0.txt:718
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-1-bm53-tests1-linux64-build0.txt:496
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-2-bm67-tests1-linux64-build0.txt:313
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-1-bm123-tests1-linux64-build25.txt:190
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-5-bm52-tests1-linux64-build2.txt:69
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-4-bm122-tests1-linux64-build12.txt:39
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-2-bm53-tests1-linux64-build12.txt:33
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-3-bm51-tests1-linux64-build0.txt:30
> mozilla-central_ubuntu64_vm-debug_test-mochitest-1-bm117-tests1-linux64-build1.txt:11
> mozilla-central_ubuntu64_vm-debug_test-mochitest-5-bm115-tests1-linux64-build29.txt:4
> mozilla-central_ubuntu64_vm-debug_test-mochitest-2-bm67-tests1-linux64-build1.txt:4
> mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-2-bm123-tests1-linux64-build2.txt:3
> mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-1-bm68-tests1-linux64-build0.txt:3

It shows up in 698 tests. A few of the most prevalent:

> 46 - browser/base/content/test/general/browser_bug553455.js
> 23 - docshell/test/navigation/test_sessionhistory.html
> 21 - toolkit/mozapps/extensions/test/browser/browser_gmpProvider.js
> 19 - browser/components/sessionstore/test/browser_394759_behavior.js
> 16 - dom/html/test/browser_bug1108547.js
> 16 - docshell/test/navigation/test_reserved.html
> 16 - docshell/test/navigation/test_not-opener.html
> 15 - toolkit/mozapps/extensions/test/browser/browser_bug577990.js
> 14 - toolkit/mozapps/extensions/test/browser/browser_searching.js
> 13 - toolkit/components/passwordmgr/test/browser/browser_notifications.js

[1] https://hg.mozilla.org/mozilla-central/annotate/49683d4e9ebd/dom/events/IMEStateManager.cpp#l948
masayuki should comment here whether we could remove the warning.
Masayuki, it looks like we also log an error message if this happens. Are you okay with changing the |if(NS_WARN_IF(aTabParent != sActiveTabParent))| to just an |if(aTabParent != sActiveTabParent)|?
Flags: needinfo?(masayuki)
Absolutely. Looks like that parent process sometimes received requests to set input content from child process but the requests are too late since focus was changed already. So, this must be possible case, not detecting unexpected case.
Flags: needinfo?(masayuki)
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Comment on attachment 8634557 [details] [diff] [review]
Remove aTabParent != sActiveTabParent warning from IMEStateManager::SetInputContextForChildProcess

Thanks!
Attachment #8634557 - Flags: review?(masayuki) → review+
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/7bdacc3df33dd96c63c183bb5b798b1e1d3b06a3
changeset:  7bdacc3df33dd96c63c183bb5b798b1e1d3b06a3
user:       Eric Rahm <erahm@mozilla.com>
date:       Wed Jul 15 22:29:18 2015 -0700
description:
Bug 1184242 - Remove aTabParent != sActiveTabParent warning from IMEStateManager::SetInputContextForChildProcess. r=masayuki
https://hg.mozilla.org/mozilla-central/rev/7bdacc3df33d
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.