Disable the device name field when sync is not connected

RESOLVED FIXED in Firefox 42

Status

()

Firefox
Sync
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: rfeeley, Assigned: eoger)

Tracking

unspecified
Firefox 42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

3 years ago
Created attachment 8634247 [details]
reconnect-sync-device.png

Because we're not sure what happens to the device name when you resume syncing, we should disable the device name field when sync is not connected.
(Assignee)

Updated

3 years ago
Depends on: 1180734
(Assignee)

Comment 1

3 years ago
Created attachment 8634432 [details] [diff] [review]
bug-1184243.patch
Attachment #8634432 - Flags: review?(markh)
(Assignee)

Comment 2

3 years ago
Comment on attachment 8634432 [details] [diff] [review]
bug-1184243.patch

Somethings went wrong when exporting the patch (it includes bug 1180734 patch). Brb fixing this
Attachment #8634432 - Flags: review?(markh)
(Assignee)

Comment 3

3 years ago
Created attachment 8634437 [details] [diff] [review]
bug-1184243.patch

Here it is
Attachment #8634432 - Attachment is obsolete: true
Attachment #8634437 - Flags: review?(markh)

Updated

3 years ago
Attachment #8634437 - Flags: review?(markh) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0a6b20a4659b
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
I have reproduced this bug on Nightly 42.0a1 (2015-07-15) on ubuntu 14.04 LTS, 32 bit!

The bug's fix is now verified on Latest Beta 42.0b3!

Build ID: 20151001142456
User Agent: Mozilla/5.0 (X11; Linux i686; rv:42.0) Gecko/20100101 Firefox/42.0

[testday-20151002]
You need to log in before you can comment on or make changes to this bug.