Closed Bug 1184249 Opened 4 years ago Closed 4 years ago

1,900 instances of "NS_ENSURE_TRUE(rootContent) failed" emitted from editor/composer/nsEditorSpellCheck.cpp during linux64 debug testing

Categories

(Core :: Spelling checker, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #338427 +++

> 1911 [NNNNN] WARNING: NS_ENSURE_TRUE(rootContent) failed: file editor/composer/nsEditorSpellCheck.cpp, line 715

This warning [1], introduced in bug 338427, shows up in the following test suites:

> mozilla-central_ubuntu64_vm-debug_test-mochitest-other-bm53-tests1-linux64-build0.txt:706
> mozilla-central_ubuntu64_vm-debug_test-mochitest-2-bm67-tests1-linux64-build1.txt:321
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-2-bm53-tests1-linux64-build12.txt:305
> mozilla-central_ubuntu64_vm-debug_test-mochitest-4-bm121-tests1-linux64-build0.txt:135
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-4-bm122-tests1-linux64-build12.txt:123
> mozilla-central_ubuntu64_vm-debug_test-mochitest-5-bm115-tests1-linux64-build29.txt:80
> mozilla-central_ubuntu64_vm-debug_test-crashtest-bm53-tests1-linux64-build28.txt:50
> mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-2-bm123-tests1-linux64-build2.txt:38
> mozilla-central_ubuntu64_vm-debug_test-reftest-4-bm121-tests1-linux64-build1.txt:38
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-1-bm123-tests1-linux64-build25.txt:28
> mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-1-bm68-tests1-linux64-build0.txt:25
> mozilla-central_ubuntu64_vm-debug_test-reftest-2-bm53-tests1-linux64-build27.txt:23
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-5-bm52-tests1-linux64-build2.txt:21
> mozilla-central_ubuntu64_vm-debug_test-mochitest-1-bm117-tests1-linux64-build1.txt:14
> mozilla-central_ubuntu64_vm-debug_test-reftest-1-bm54-tests1-linux64-build2.txt:2
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-3-bm118-tests1-linux64-build0.txt:1
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-2-bm117-tests1-linux64-build8.txt:1

It shows up in 217 tests. A few of the most prevalent:

> 664 - widget/tests/test_imestate.html
> 356 - dom/imptests/editing/conformancetest/test_event.html
> 200 - dom/html/test/test_bug430351.html
> 58 - layout/base/tests/test_reftests_with_caret.html
> 56 - dom/tests/mochitest/general/test_bug1012662_editor.html
> 32 - dom/events/test/test_bug409604.html
> 20 - editor/libeditor/tests/test_contenteditable_focus.html
> 18 - editor/libeditor/tests/test_bug551704.html
> 18 - dom/html/test/test_bug446483.html
> 12 - layout/base/tests/test_event_target_radius.html

[1] https://hg.mozilla.org/mozilla-central/annotate/49683d4e9ebd/editor/composer/nsEditorSpellCheck.cpp#l715
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Attachment #8636895 - Flags: review?(ehsan) → review+
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/054e277b51686989d046bbaa490129d439696368
changeset:  054e277b51686989d046bbaa490129d439696368
user:       Eric Rahm <erahm@mozilla.com>
date:       Wed Jul 22 09:24:59 2015 -0700
description:
Bug 1184249 - Remove warning if rootContent is null in nsEditorSpellCheck::UpdateCurrentDictionary. r=ehsan
https://hg.mozilla.org/mozilla-central/rev/054e277b5168
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.