Closed Bug 1184260 Opened 4 years ago Closed 4 years ago

1,600 instances of "NS_ENSURE_TRUE(sf) failed" emitted from docshell/base/nsDocShell.cpp during linux64 debug testing

Categories

(Core :: Document Navigation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

> 1630 [NNNNN] WARNING: NS_ENSURE_TRUE(sf) failed: file docshell/base/nsDocShell.cpp, line 6472

This warning [1] shows up in the following test suites:

> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-1-bm122-tests1-linux64-build19.txt:712
> mozilla-central_ubuntu64_vm-debug_test-mochitest-other-bm53-tests1-linux64-build0.txt:346
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-1-bm53-tests1-linux64-build0.txt:296
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-2-bm67-tests1-linux64-build0.txt:160
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-3-bm122-tests1-linux64-build17.txt:76
> mozilla-central_ubuntu64_vm-debug_test-mochitest-jetpack-bm123-tests1-linux64-build2.txt:10
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-2-bm117-tests1-linux64-build8.txt:8
> mozilla-central_ubuntu64_vm-debug_test-mochitest-1-bm117-tests1-linux64-build1.txt:6
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-3-bm118-tests1-linux64-build0.txt:4
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-1-bm123-tests1-linux64-build25.txt:4
> mozilla-central_ubuntu64_vm-debug_test-crashtest-bm53-tests1-linux64-build28.txt:4
> mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-2-bm123-tests1-linux64-build2.txt:2
> mozilla-central_ubuntu64_vm-debug_test-reftest-3-bm52-tests1-linux64-build0.txt:2

It shows up in 70 tests. A few of the most prevalent:

> 140 - toolkit/mozapps/extensions/test/browser/browser_details.js
> 110 - toolkit/content/tests/chrome/test_popup_button.xul
> 110 - toolkit/content/tests/chrome/test_popup_attribute.xul
> 108 - toolkit/mozapps/extensions/test/browser/browser_gmpProvider.js
> 108 - toolkit/content/tests/widgets/test_menubar.xul
> 96 - toolkit/mozapps/extensions/test/browser/browser_types.js
> 80 - toolkit/mozapps/extensions/test/browser/browser_searching.js
> 72 - toolkit/mozapps/extensions/test/browser/browser_inlinesettings.js
> 70 - toolkit/mozapps/extensions/test/browser/browser_bug562797.js
> 56 - toolkit/mozapps/extensions/test/browser/browser_inlinesettings_info.js

[1] https://hg.mozilla.org/mozilla-central/annotate/49683d4e9ebd/docshell/base/nsDocShell.cpp#l6483
Blocks: logspam
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Attachment #8636893 - Flags: review?(bugs) → review+
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/234afcf232d46e3705f76f16333c5fa5c05da35a
changeset:  234afcf232d46e3705f76f16333c5fa5c05da35a
user:       Eric Rahm <erahm@mozilla.com>
date:       Wed Jul 22 09:24:57 2015 -0700
description:
Bug 1184260 - Remove warning if GetRootScrollFrame returns null in GetCurScrollPos. r=smaug
https://hg.mozilla.org/mozilla-central/rev/234afcf232d4
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.