[Raptor] Allow remote Marionette connections

RESOLVED FIXED in FxOS-S3 (24Jul)

Status

Firefox OS
Gaia::PerformanceTest
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Eli, Assigned: Eli)

Tracking

unspecified
FxOS-S3 (24Jul)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
When Raptor supports Marionette, we need to support connecting to remote devices, as that is how bitbar devices are set up. Specifically:

MARIONETTE_HOST and MARIONETTE_PORT are provided in the environment.
Handle forwarding adb when device is connected to localhost.
(Assignee)

Comment 1

3 years ago
Created attachment 8635495 [details] [review]
Link to Github pull-request: https://github.com/eliperelman/mozilla-raptor/pull/4
Attachment #8635495 - Flags: review?(rwood)
(Assignee)

Comment 2

3 years ago
Created attachment 8635592 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/raptor/pull/5
Attachment #8635495 - Attachment is obsolete: true
Attachment #8635495 - Flags: review?(rwood)
Attachment #8635592 - Flags: review?(rwood)

Comment 3

3 years ago
Cmd line options work, but env vars don't:

https://gist.github.com/rwood-moz/6eb2ff0aecff0450b6ef

Comment 4

3 years ago
Comment on attachment 8635592 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/raptor/pull/5

LGTM and works great with latest update. Didn't test with remote bitbar device, just tested locally, cmd line and env vars, multiple devices attached. ADB is now fw automatically by default, to the ANDROID_SERIAL device. Ran coldlaunch, restart, and reboot test, adb connection is retained through multiple reboot runs too.
Attachment #8635592 - Flags: review?(rwood) → review+
(Assignee)

Comment 5

3 years ago
In master: https://github.com/mozilla-b2g/raptor/commit/7b3bd98f9bf58bbfcf6a0a50d804c0d1ae37b3ef
In npm: @mozilla/raptor v1.2.0
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.