1184280 - 1, 300 instances of "NS_ENSURE_TRUE(mDisabledJSAndPlugins) failed" emitted from editor/composer/nsEditingSession.cpp during linux64 debug testing

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Eric Rahm [:erahm]]

+++ This bug was initially created as a clone of Bug #572618 +++

> 1291 [NNNNN] WARNING: NS_ENSURE_TRUE(mDisabledJSAndPlugins) failed: file editor/composer/nsEditingSession.cpp, line 209

Considering we return NS_OK, we can probably just make this a |if (!mDisabledJSAndPlugins)|.

This warning [1], introduced in bug 572618, shows up in the following test suites:

> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-2-bm53-tests1-linux64-build12.txt:210
> mozilla-central_ubuntu64_vm-debug_test-mochitest-2-bm67-tests1-linux64-build1.txt:208
> mozilla-central_ubuntu64_vm-debug_test-mochitest-4-bm121-tests1-linux64-build0.txt:192
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-4-bm122-tests1-linux64-build12.txt:143
> mozilla-central_ubuntu64_vm-debug_test-crashtest-bm53-tests1-linux64-build28.txt:138
> mozilla-central_ubuntu64_vm-debug_test-mochitest-5-bm115-tests1-linux64-build29.txt:83
> mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-2-bm123-tests1-linux64-build2.txt:61
> mozilla-central_ubuntu64_vm-debug_test-mochitest-other-bm53-tests1-linux64-build0.txt:60
> mozilla-central_ubuntu64_vm-debug_test-reftest-4-bm121-tests1-linux64-build1.txt:59
> mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-1-bm68-tests1-linux64-build0.txt:33
> mozilla-central_ubuntu64_vm-debug_test-reftest-2-bm53-tests1-linux64-build27.txt:30
> mozilla-central_ubuntu64_vm-debug_test-mochitest-1-bm117-tests1-linux64-build1.txt:25
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-1-bm123-tests1-linux64-build25.txt:16
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-5-bm52-tests1-linux64-build2.txt:12
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-2-bm67-tests1-linux64-build0.txt:5
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-1-bm122-tests1-linux64-build19.txt:5
> mozilla-central_ubuntu64_vm-debug_test-reftest-1-bm54-tests1-linux64-build2.txt:3
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-3-bm118-tests1-linux64-build0.txt:3
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-2-bm117-tests1-linux64-build8.txt:3
> mozilla-central_ubuntu64_vm-debug_test-reftest-3-bm52-tests1-linux64-build0.txt:2

It shows up in 372 tests. A few of the most prevalent:

> 356 - dom/imptests/editing/conformancetest/test_event.html
> 70 - layout/base/tests/test_reftests_with_caret.html
> 52 - editor/libeditor/tests/test_bug611182.html
> 50 - editor/libeditor/tests/test_root_element_replacement.html
> 32 - editor/libeditor/tests/test_bug520189.html
> 18 - dom/html/test/test_bug446483.html
> 12 - file:///builds/slave/test/build/tests/reftest/tests/editor/reftests/824080-4.html
> 10 - editor/libeditor/tests/test_dom_input_event_on_htmleditor.html
> 10 - editor/libeditor/tests/test_bug455992.html
> 8 - file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/bugs/613433-1.html

[1] https://hg.mozilla.org/mozilla-central/annotate/49683d4e9ebd/editor/composer/nsEditingSession.cpp#l209

Comment 1

[Eric Rahm [:erahm]]

Attachment: Remove warning about mDisabledJSAndPlugins being false

Comment 2

[Eric Rahm [:erahm]]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/9f7b5a358a7692659af7f79829d5d31f63894d25
changeset:  9f7b5a358a7692659af7f79829d5d31f63894d25
user:       Eric Rahm <[e-mail]>
date:       Wed Jul 15 14:48:09 2015 -0700
description:
Bug 1184280 - Remove warning about mDisabledJSAndPlugins being false. r=ehsan

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9f7b5a358a76