1184307 - Performance graphs use hardcoded strings for min, max, avg..

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Théo Chevalier]

Attachment: Latest Nightly, French (tabs)

In JS Profiler / Performance panel, some tabs and associated tooltips are left untranslated.

From screenshots I can spot:

Waterfall 
Call Tree
Flame Chart
Cycle Collection (both label and tooltip)
avg
fps
"min", "max" (not sure)
Enable multiprocess Firefox in preferences, etc.
Buffer x% full


Those strings seem hardcoded, since I can't find them in our localization files. Which is really bad because Aurora is affected and we're string frozen.

Comment 1

[Théo Chevalier]

Attachment: Latest Dev Edition, French (New profiling)

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Going down the list, taking care of most of these in bug 1163763; the ones that aren't, however are the min/max/avg indicators for the graphs -- I'll update this bug for that issue. Thanks!

Should probably create a widgets/graphs localization file for this.

Comment 3

[Lin Clark [:linclark]]

Attachment: Bug1184307.patch

This patch wires it together by:
- Creating a browser/devtools/graphs.properties
- Listing that file in browser/locales/jar.mn
- Using the properties in browser/devtools/shared/widgets/LineGraphWidget.js

Let me know if any naming should be changed.

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8647574 [details] [diff] [review]
Bug1184307.patch

Review of attachment 8647574 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect. Thanks, Lin! Will get this patch in shortly, as well

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

Ccing Victor so he's aware of this l10n file for all our shared graphs -- if you can think of other un-L10N'd graph strings, let's make follow up bugs

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/b8e7689d9b8e

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b8e7689d9b8e