Closed Bug 1184351 Opened 9 years ago Closed 8 years ago

Intermittent e10s & debug mixed-content/blockable picture-tag/top-level/no-redirect/{no-}opt-in-blocks.https.html | opt_in_method: no-opt-in fail

Categories

(Core :: DOM: Security, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
e10s + ---
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: KWierso, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure, Whiteboard: [domsecurity-intermittent])

Attachments

(1 file)

13:00:01 INFO - context_nesting: top-level
13:00:01 INFO - redirection: swap-scheme-redirect
13:00:01 INFO - subresource: object-tag
13:00:01 INFO - expectation: blocked - assert_true: Expected test to complete. expected true got false
13:00:01 INFO - runTest/</<@https://web-platform.test:8443/mixed-content/generic/mixed-content-test-case.js?pipe=sub:96:9
13:00:01 INFO - Test.prototype.step@https://web-platform.test:8443/resources/testharness.js:1371:20
13:00:01 INFO - runTest/<@https://web-platform.test:8443/mixed-content/generic/mixed-content-test-case.js?pipe=sub:95:7
13:00:01 INFO - TEST-OK | /mixed-content/blockable/no-opt-in/cross-origin-http/object-tag/top-level/swap-scheme-redirect/no-opt-in-blocks.https.html | took 1282ms
13:00:01 INFO - TEST-START | /mixed-content/blockable/no-opt-in/cross-origin-http/picture-tag/top-level/keep-scheme-redirect/no-opt-in-blocks.https.html
13:00:01 INFO - PROCESS | 3148 | WARNING: content window passed to PrivateBrowsingUtils.isWindowPrivate. Use isContentWindowPrivate instead (but only for frame scripts).
13:00:01 INFO - PROCESS | 3148 | pbu_isWindowPrivate@resource://gre/modules/PrivateBrowsingUtils.jsm:25:14
13:00:01 INFO - PROCESS | 3148 | nsBrowserAccess.prototype.openURI@chrome://browser/content/browser.js:15965:21
13:00:01 INFO - PROCESS | 3148 | __marionetteFunc@dummy file:27:30
13:00:01 INFO - PROCESS | 3148 | @dummy file:36:3
13:00:01 INFO - PROCESS | 3148 | executeWithCallback@chrome://marionette/content/listener.js:771:5
13:00:01 INFO - PROCESS | 3148 | executeAsyncScript@chrome://marionette/content/listener.js:645:3
13:00:02 INFO - TEST-PASS | /mixed-content/blockable/no-opt-in/cross-origin-http/picture-tag/top-level/keep-scheme-redirect/no-opt-in-blocks.https.html | [MixedContentTestCase] The test scenario should be valid.
13:00:02 INFO - TEST-UNEXPECTED-FAIL | /mixed-content/blockable/no-opt-in/cross-origin-http/picture-tag/top-level/keep-scheme-redirect/no-opt-in-blocks.https.html | opt_in_method: no-opt-in
13:00:02 INFO - origin: cross-origin-http
13:00:02 INFO - source_scheme: https
13:00:02 INFO - context_nesting: top-level
13:00:02 INFO - redirection: keep-scheme-redirect
13:00:02 INFO - subresource: picture-tag
13:00:02 INFO - expectation: blocked - assert_true: Expected test to complete. expected true got false
13:00:02 INFO - runTest/</<@https://web-platform.test:8443/mixed-content/generic/mixed-content-test-case.js?pipe=sub:96:9
13:00:02 INFO - Test.prototype.step@https://web-platform.test:8443/resources/testharness.js:1371:20
13:00:02 INFO - runTest/<@https://web-platform.test:8443/mixed-content/generic/mixed-content-test-case.js?pipe=sub:95:7
13:00:02 INFO - TEST-OK | /mixed-content/blockable/no-opt-in/cross-origin-http/picture-tag/top-level/keep-scheme-redirect/no-opt-in-blocks.https.html | took 1192ms
13:00:03 WARNING - u'runner_teardown' ()
James, this is failing frequently and the annotations look completely messed up unless I'm missing something?
http://mxr.mozilla.org/mozilla-central/source/testing/web-platform/meta/mixed-content/blockable/http-csp/same-host-http/picture-tag/top-level/no-redirect/opt-in-blocks.https.html.ini
Flags: needinfo?(james)
I've hidden W(5) on Linux/Linux64 debug across all trees for the time-being.
Yes, of course I can disable this. But it's not good that no attempt was made to get a relevant engineer to examine the problem before disabling the job, and even worse that you hid the job rather than just disabling the test yourself.
Component: web-platform-tests → Security
Flags: needinfo?(james)
Product: Testing → Core
Keywords: leave-open
Christoph, is this something you'd have time to look at? Otherwise, do you know of someone else who might? The worst of the failures have been taken care of via disabling on Linux debug, but we're still seeing OSX and Linux opt failures at a lower frequency.
Flags: needinfo?(mozilla)
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #70)
> Christoph, is this something you'd have time to look at? Otherwise, do you
> know of someone else who might? The worst of the failures have been taken
> care of via disabling on Linux debug, but we're still seeing OSX and Linux
> opt failures at a lower frequency.

I will take a look this week. Also CC'ing Tanvi who basically owns mixed content blocking.
Flags: needinfo?(mozilla)
Unfortunately I can't reproduce the error locally, but as far as I understand the test makes sure that fetch blocks mixed content. I am getting the following warning on the console:

> 'NS_FAILED(rv) || NS_CP_REJECTED(shouldLoad)', file /home/ckerschb/moz/mc/dom/fetch/FetchDriver.cpp, line 126

which seems correct. So presumably, since the test does not finish intermittently (see Comment 0), I assume that things might start to go wrong around here [1].

I really have no idea at the moment, so let's have a desperate attempt and ask :nsm who was involved in fixing many of the fetch bugs (Bug 1184607, Bug 1139665, Bug 1039846) if he could bring some light into the dark here.

[1] http://mxr.mozilla.org/mozilla-central/source/dom/fetch/FetchDriver.cpp#128
Flags: needinfo?(nsm.nikhil)
I am going to punt on this too for now as I can't reproduce it either. Specifically I only tested /mixed-content/blockable/http-csp/cross-origin-http/fetch-request/top-level/keep-scheme-redirect/opt-in-blocks.https.html

I was able to easily reproduce /mixed-content/blockable/http-csp/same-host-http/picture-tag/top-level/no-redirect/opt-in-blocks.https.html though.
Summary: Intermittent no-opt-in-blocks.https.html | opt_in_method: no-opt-in → Intermittent mixed-content/blockable/no-opt-in/same-host-http/picture-tag/top-level/no-redirect/no-opt-in-blocks.https.html | opt_in_method: no-opt-in
I'm using this bug to cover the remaining picture-tag mixed-content/blockable failures we're seeing on e10s (as a carry-over from bug 1205654) and debug variants of a few platforms.

See:
testing/web-platform/meta/mixed-content/blockable/http-csp/same-host-http/picture-tag/top-level/no-redirect/opt-in-blocks.https.html.ini
testing/web-platform/meta/mixed-content/blockable/no-opt-in/cross-origin-http/picture-tag/top-level/no-redirect/no-opt-in-blocks.https.html.ini
testing/web-platform/meta/mixed-content/blockable/no-opt-in/same-host-http/picture-tag/top-level/no-redirect/no-opt-in-blocks.https.html.ini
Blocks: e10s-tests
tracking-e10s: --- → ?
Component: Security → DOM: Security
Flags: needinfo?(mozilla)
Summary: Intermittent mixed-content/blockable/no-opt-in/same-host-http/picture-tag/top-level/no-redirect/no-opt-in-blocks.https.html | opt_in_method: no-opt-in → Intermittent e10s & debug mixed-content/blockable picture-tag/top-level/no-redirect/{no-}opt-in-blocks.https.html | opt_in_method: no-opt-in fail
Whiteboard: [domsecurity-intermittent]
See Also: → 1261587
(In reply to Ryan VanderMeulen [:RyanVM] from comment #115)
> I'm using this bug to cover the remaining picture-tag
> mixed-content/blockable failures we're seeing on e10s (as a carry-over from
> bug 1205654) and debug variants of a few platforms.

OK, makes sense to me. Was there anything in particular the needinfo was for?
Flags: needinfo?(ckerschb)
No, was just moving it over from the other bug.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #8747116 - Flags: review?(james) → review+
https://hg.mozilla.org/mozilla-central/rev/0939fd079113
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Depends on: 1268915
Blocks: 1214473
Blocks: 1266957
You need to log in before you can comment on or make changes to this bug.