1184369 - Wrong styling for the onboarding tour paragraph links

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Justin Crawford [:hoosteeno] [:jcrawford]]

Attachment: Screen Shot 2015-07-15 at 4.38.47 PM.png

Testing environment:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:42.0) Gecko/20100101 Firefox/42.0 ID:20150715163543 CSet: e786406bc683

Steps to replicate:
1. Open Firefox using a clean profile;
2. Open a newtab page;
3. See the inline link to "Privacy Notice"

Results:
The styling of links in paragraph text does not resemble the style guide[0]. Specifically...
* Default colors (blue, purple) for unvisited and visited links
* Default text decoration (underline)

[1] Page 12 here https://bug1150228.bugzilla.mozilla.org/attachment.cgi?id=8592387

Comment 1

[Justin Crawford [:hoosteeno] [:jcrawford]]

Attachment: Screen Shot 2015-07-15 at 4.59.09 PM.png

Aaron, I think the styleguide does not call this out specifically. Should the same styles apply to links in paragraph text as apply to footer links? That would be...
* never underline
* a, a:visited get blue, #4A90E2
* a:hover gets black, #000000

Screenshot of this attached.

Comment 2

[Aaron]

Justin, yes - the styles should be as you've specified. Thanks for catching that!

Comment 3

[Justin Crawford [:hoosteeno] [:jcrawford]]

Attachment: bug1184369.patch

Comment 4

[Marina Samuel [:emtwo]]

Comment on attachment 8635579 [details] [diff] [review]
bug1184369.patch

Review of attachment 8635579 [details] [diff] [review]:
-----------------------------------------------------------------

Nice. Just a note for landing: bug 1183932 also makes the same change to `#newtab-intro-text > p > a` so if that one lands first, this one may need to be rebased.

Comment 5

[Carsten Book [:Tomcat]]

seems this needs a rebase

Parsing... done
adding 1184369 to series file
renamed 1184369 -> bug1184369.patch
applying bug1184369.patch
patching file browser/base/content/newtab/newTab.css
Hunk #1 FAILED at 849
1 out of 1 hunks FAILED -- saving rejects to file browser/base/content/newtab/newTab.css.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and refresh bug1184369.patch

could you take a look, thanks!

Comment 6

[Justin Crawford [:hoosteeno] [:jcrawford]]

Attachment: Add hover styling to paragraph links in newtab intro

Comment 7

[Ryan VanderMeulen [:RyanVM]]

MozReview rev 08c9f8f4c0798e6f04cf791fbe13f6287126f070 still doesn't apply cleanly to fx-team tip :(

Comment 8

[Justin Crawford [:hoosteeno] [:jcrawford]]

Attachment: Add hover styling to paragraph links in newtab intro

Comment 9

[Justin Crawford [:hoosteeno] [:jcrawford]]

I believe I have just accomplished my first hg rebase, and https://bugzilla.mozilla.org/attachment.cgi?id=8643978 is the resulting patch. I really hope this will apply cleanly. Thanks for your patience with the hg newbie. :)

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/bb90b2703de6

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bb90b2703de6