Closed Bug 1184369 Opened 8 years ago Closed 8 years ago

Wrong styling for the onboarding tour paragraph links


(Firefox :: New Tab Page, defect)

Not set



Firefox 42
Tracking Status
firefox42 --- fixed


(Reporter: hoosteeno, Assigned: hoosteeno)



(4 files, 1 obsolete file)

Testing environment:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:42.0) Gecko/20100101 Firefox/42.0 ID:20150715163543 CSet: e786406bc683

Steps to replicate:
1. Open Firefox using a clean profile;
2. Open a newtab page;
3. See the inline link to "Privacy Notice"

The styling of links in paragraph text does not resemble the style guide[0]. Specifically...
* Default colors (blue, purple) for unvisited and visited links
* Default text decoration (underline)

[1] Page 12 here
Aaron, I think the styleguide does not call this out specifically. Should the same styles apply to links in paragraph text as apply to footer links? That would be...
* never underline
* a, a:visited get blue, #4A90E2
* a:hover gets black, #000000

Screenshot of this attached.
Flags: needinfo?(athornburgh)
Justin, yes - the styles should be as you've specified. Thanks for catching that!
Flags: needinfo?(athornburgh)
Assignee: nobody → hoosteeno
Comment on attachment 8635579 [details] [diff] [review]

Review of attachment 8635579 [details] [diff] [review]:

Nice. Just a note for landing: bug 1183932 also makes the same change to `#newtab-intro-text > p > a` so if that one lands first, this one may need to be rebased.
Attachment #8635579 - Flags: feedback? → review+
seems this needs a rebase

Parsing... done
adding 1184369 to series file
renamed 1184369 -> bug1184369.patch
applying bug1184369.patch
patching file browser/base/content/newtab/newTab.css
Hunk #1 FAILED at 849
1 out of 1 hunks FAILED -- saving rejects to file browser/base/content/newtab/newTab.css.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and refresh bug1184369.patch

could you take a look, thanks!
Flags: needinfo?(hoosteeno)
Keywords: checkin-needed
Flags: needinfo?(hoosteeno)
Attachment #8637500 - Flags: review?(msamuel)
Attachment #8637500 - Flags: review?(msamuel) → review+
MozReview rev 08c9f8f4c0798e6f04cf791fbe13f6287126f070 still doesn't apply cleanly to fx-team tip :(
Keywords: checkin-needed
Attachment #8637500 - Attachment is obsolete: true
I believe I have just accomplished my first hg rebase, and is the resulting patch. I really hope this will apply cleanly. Thanks for your patience with the hg newbie. :)
Keywords: checkin-needed
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
You need to log in before you can comment on or make changes to this bug.