1184395 - Release the observer service when the cookie service shuts down

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect)

Comment 1

[(no longer active)]

Attachment: Release the observer service when the cookie service shuts down

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/00ec02ec876e

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Backed out for crashes.
https://treeherder.mozilla.org/logviewer.html#?job_id=11773957&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec14da8e5205

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Useful-looking assert on the debug failures:
https://treeherder.mozilla.org/logviewer.html#?job_id=11776254&repo=mozilla-inbound

Comment 5

[(no longer active)]

Attachment: Release the observer service when the cookie service shuts down

Comment 6

[Josh Matthews [:jdm]]

Comment on attachment 8635276 [details] [diff] [review]
Release the observer service when the cookie service shuts down

Why don't we just remove mObserverService instead? I'm not keen on trying to figure out when it's appropriate to use mObserverService instead of fetching it on demand.

Comment 7

[(no longer active)]

Attachment: Remove nsCookieService::mObserverService

That's a great idea!

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7b25e64b1eaa

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7b25e64b1eaa