1184423 - Properly report OOM when initializing the RematerizedFrameTable fails

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

js::HashMap doesn't report OOM when operations fail, so we have to do it
ourselves.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Properly report OOM when initializing the RematerizedFrameTable fails

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Properly report OOM when initializing the RematerizedFrameTable fails

Comment 3

[Shu-yu Guo [:shu]]

Comment on attachment 8634554 [details] [diff] [review]
Properly report OOM when initializing the RematerizedFrameTable fails

Review of attachment 8634554 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, good find. Thanks for patch!

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

There's actually another case here too. ni myself to just audit the whole RematerializedFrameTable oom handling so I don't forget about it.

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Properly report OOM when adding a rematerialized frame to the current JitActivation fails

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/26de9419c0f0
https://hg.mozilla.org/integration/mozilla-inbound/rev/d756733ac4c4

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/26de9419c0f0
https://hg.mozilla.org/mozilla-central/rev/d756733ac4c4