1184432 - Use nsClassHashtable::ConstIter in GeckoMediaPluginServiceParent::AsyncShutdownPluginStates

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Spawned from bug 1183433 comment 4, which needs to be uplifted and therefore couldn't use the new iterator.
This bug is to replace the now-obsolete EnumerateRead with ConstIter, which is only available in 42 and later (see bug 1181445).

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Or use range-for if it becomes available soon (see bug 1149833).

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1184432-asyncshutdown-reporting-using-hastable-iter.patch

Use nsClassHashtable::ConstIter instead of now-obsolete EnumerateRead, in GeckoMediaPluginServiceParent::AsyncShutdownPluginStates.

(Taking this patch off my mental plate. If range-based for gets enabled soon, it will be a very small increment on top of this patch.)

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8635022 [details] [diff] [review]
1184432-asyncshutdown-reporting-using-hastable-iter.patch

Review of attachment 8635022 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/gmp/GMPServiceParent.cpp
@@ +424,5 @@
>    state->mLastStateDescription = aState;
>    note += '{';
> +  bool firstPlugin = true;
> +  for (auto pluginIt = mStates.ConstIter(); !pluginIt.Done(); pluginIt.Next()) {
> +    if (!firstPlugin) { note += ','; } else { firstPlugin = false; }

if (x) {
  // ...
} else {
  // ...
}

no single line if blocks.

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=72d11c9f7fab

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca42fdde60f6

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ca42fdde60f6