1184434 - A build definition manager for managing build config

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Ricky Chien [:rickychien] (inactive)]

As described in NewBuildSystem at https://wiki.mozilla.org/Gaia/Build/NewBuildSystem#Build_config_manager

Ideally, there should have a management component to deal with these build definitions ex: PRODUCTION=1, DEBUG=1, GAIA_DISTRIBUTION_DIR=xxx...etc and retrieve from a default config.json as well as user inputs, and then pass them from configure.js to app/configure.js.

Comment 1

[Ricky Chien [:rickychien] (inactive)]

Attachment: config-manager

Hi Gareth, there is a WIP simple package which would be useful for managing / using build config.

Feel free to give me your options if you have any concerns.

Comment 2

[Ricky Chien [:rickychien] (inactive)]

otherwise we can use existed good solution like https://github.com/indexzero/nconf.

Comment 3

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8635959 [details]
config-manager

>https://github.com/rickychien/config-manager

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Attachment: PR for confidant

Comment 5

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8639119 [details] [review]
PR for confidant

Still some work to do here but a good start. I left some comments on GH. Thanks for the patch Ricky!

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8639119 [details] [review]
PR for confidant

PR has updated for getting rid of nconf and I would create another cfg-manager for managing and merging env and build-config.json.

Please review it kindly thanks!

Comment 7

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8639119 [details] [review]
PR for confidant

Comments had happened on GH and PR has beend merged.

Comment 8

[Ricky Chien [:rickychien] (inactive)]

Let's close this since pull request is merged (see https://github.com/gaye/confidant/pull/31).