1184473 - update graphite support to handle cross space contextuals

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[martin_hosken]

Attachment: awamitest.zip

The Graphite development team are in final testing of a new version of the graphite engine that provides among other things collision avoidance support for scripts like Nastaliq Arabic. The integration of this hew version should be straightforward, except to take advantage of the new kerning support, gecko needs to be able to handle strings with spaces in them. These are marked for a face as being space contextual fonts. The API already exits, etc.

It would be good to update the integration in parallel with the final testing (targetting 1/Aug release) in order to shake down upstream bugs.

The source code is available from the default branch of the graphite hg repository.

Attached a sample html file, font (which won't load in current graphite engine) and pdf of sample rendering.

Comment 1

[Jonathan Kew [:jfkthame]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3796d37ce8a

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bypass the word cache for graphite fonts that include space contextuals

This implements the minimal support we need on the gecko side; once the graphite engine is also updated, this allows the Awami nastaliq font to render correctly, including inter-word positioning adjustments. (Not posting a patch for the graphite lib update yet, as work is still in progress upstream; we'll handle that in a new bug once the release is ready.)

Comment 3

[Jonathan Kew [:jfkthame]]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/16e644500bc3c20705caeab48705abe2813e4874
changeset:  16e644500bc3c20705caeab48705abe2813e4874
user:       Jonathan Kew <[e-mail]>
date:       Mon Aug 03 09:04:59 2015 +0100
description:
Bug 1184473 - Bypass the word cache for graphite fonts that include space contextuals. r=jdaggett

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/16e644500bc3