1184476 - [LogShake] There is no error message when you tap a notification after renaming a log folder

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Johan Lorenzo [:jlorenzo]]

STR
1. Activate LogShake
2. With an external app (like Files or File manager) rename the folder you just created with logshake.
3. Tap the notification

Expected results
An error message saying that logs cannot be found at a given path is displayed.

Actual results
Nothing happens. The notification remains in the notification center.

Comment 1

[:gerard-majax]

We have code path to handle errors when accessing the logfiles. It would be a regression if we have no error dialog ...

Comment 2

[Johan Lorenzo [:jlorenzo]]

That's a regression, then. I repro'd the problem on:
Build ID               20150713103207
Gaia Revision          a7439b6ca88264734171ff5ea0b6a0b8df3f258e
Gaia Date              2015-07-12 17:48:25
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/38d03bf4616e
Gecko Version          42.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150619.224059
Firmware Date          Fri Jun 19 22:41:08 UTC 2015
Bootloader             s1

Comment 3

[:gerard-majax]

And what was the last good one?

Comment 4

[:gerard-majax]

That's probably not a regression. It's just that we do not have a "operation" field in the error object. But we have a DOMError with "name" being "NotFoundError".

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] lissyx:bug1184476 > mozilla-b2g:master

Comment 6

[:gerard-majax]

I've rebased onto bug 1079763 that was not landed while the Gecko part did. This made us hit the "always get a DOMError" code path, because bug 1079763 do changes the message sent from Gecko to Gaia for the notification. This means we were getting a real error. With this landed, this patch now does what was expected.

I just changed a little bit the onError handle to make it expose an error dialog just once.

Comment 7

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8634674 [details] [review]
[gaia] lissyx:bug1184476 > mozilla-b2g:master

I tested the following:
* Rename the folder => OK
* Rename one file in the folder => OK
* Delete one file in the folder => OK
* Delete the folder => OK
* Tap multiple times the notification => You have to dismiss as many times the error message (see Github comment)

Like discussed on IRC, I think some files are not worth to be mandatory (the screenshot for instance) and can be inadvertently deleted by the user (thanks to the gallery). With the current implementation, the user is not able to share the logs at all.

:gerard-majax said implementing this check would be overkill: How do we know which file is important and which is not? Gecko is the only one to know about the content of the file list. As it's an edge case, I agree with not handling it.

Comment 8

[Dale Harvey (:daleharvey)]

Comment on attachment 8634674 [details] [review]
[gaia] lissyx:bug1184476 > mozilla-b2g:master

Nice, cheers for this, looks great

Comment 9

[:gerard-majax]

Green: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=51e582b7a6d86bd0c4ea85bed6066a47454e48e2

Comment 10

[:gerard-majax]

https://github.com/mozilla-b2g/gaia/commit/522f9ae68b59e9e58ea50b50163f858c050a2c2a