1184541 - Create a StructuredCloneHelperInternal and use it in the Console API

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrea Marchesini [:baku]]

Attachment: clone1.patch

Console API has a custom StructuredClone algorithm use because we transfer objects from workers to the main-thread as strings (except blobs).

Comment 1

[Andrea Marchesini [:baku]]

Attachment: clone1.patch

Comment 2

[Andrea Marchesini [:baku]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=94ab6e5ebf4c

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8635282 [details] [diff] [review]
clone1.patch


>+StructuredCloneHelperInternal::Read(JSContext* aCx,
>+                                    JS::MutableHandle<JS::Value> aValue)
>+{
>+  MOZ_ASSERT(mBuffer, "Read() without Write() is not allowed.");
>+
>+  if (!mBuffer->read(aCx, aValue, &gCallbacks, this)) {
>+    return false;
>+  }
>+
>+  mBuffer = nullptr;
Why we don't set buffer to null if read fails?
I think we should.

Comment 4

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aba974f71925

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/aba974f71925

Comment 6

[pipcet]

I think this change caused bug 1264613. As the Structured Clone API stands, cloning an object as a non-object is not allowed: it confuses our object reference counts.