1184566 - [l10n: ar] Updated file 'firefox/sync.lang' for SVN repository

Status: RESOLVED FIXED

(www.mozilla.org :: L10N, defect)

Description

[Abdelrahman Samy]

Attachment: firefox-sync.lang.txt

I finished translating all the strings.

Comment 1

[Rami Khader]

Strings are reviewed and committed

Comment 2

[Francesco Lodolo [:flod]]

I reverted the file you committed in r144455.

As in bug 1184561, make sure to check what you're committing, especially if coming from new contributors.

Not UTF-8, removed ; at the beginning of the English strings, changed spacing (empty lines) between strings.

Comment 3

[Francesco Lodolo [:flod]]

I copied over the strings in the attachment to the correct file, please verify if everything looks good in r144459.

For the future, please always make sure to attach the file you download from SVN using the "Your translated file" link.
https://l10n.mozilla-community.org/~pascalc/langchecker/?locale=ar#firefox/whatsnew_38.lang

Also make sure to use a proper text editor, for example SublimeText, Notepad++, etc.

Comment 4

[Rami Khader]

Thanks Francesco, The file look good and also checked it on the website..
I took notes for all your comments.

Comment 5

[Francesco Lodolo [:flod]]

OK, marking fixed then.

Note that your files didn't have any issues. Fixing empty lines is easy and done automatically by scripts, it's a lot harder to understand what happened when a file with the wrong encoding lands (in this case it was considered binary on my system).

Comment 6

[Rami Khader]

I downloaded Notepad++ and I checked now the settings for that to make sure that it is saved with UTF8.
I will inform the localizers too about this.

Comment 7

[Francesco Lodolo [:flod]]

One more suggestion: before committing, always run "svn diff" to check what the actual differences are.
If you're on *nix systems, you can pipe the command, e.g. svn diff|gedit

Comment 8

[Rami Khader]

I did that with the last commit to make sure that there is nothing missing in the file. I think I have more understanding of the process now.