Upgrade requests to 2.7.0

RESOLVED FIXED

Status

Developer Services
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: gps, Assigned: gps)

Tracking

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
version-control-tools has the requests package vendored in the repository. It is currently on version 2.3.0. We should upgrade to 2.7.0 because it is newer and has some bug fixes, including a CVE.
(Assignee)

Comment 1

3 years ago
Created attachment 8634770 [details]
MozReview Request: requests: upgrade to requests 2.7.0 (bug 1184593); r?smacleod

requests: upgrade to requests 2.7.0 (bug 1184593); r?smacleod

requests 2.3.0 is old and there are some bugs in it and urllib3 that are
nice to have. One of the fixed bugs prevents a ZeroReturnError from
causing havoc in the Selelnium tests.
Attachment #8634770 - Flags: review?(smacleod)
Comment on attachment 8634770 [details]
MozReview Request: requests: upgrade to requests 2.7.0 (bug 1184593); r?smacleod

https://reviewboard.mozilla.org/r/13441/#review12145

I didn't realize, or forgot, that we bundle requests with vct... huh. My review is of your commit message.
Attachment #8634770 - Flags: review?(smacleod) → review+
(Assignee)

Comment 3

3 years ago
url:        https://hg.mozilla.org/hgcustom/version-control-tools/rev/9803b2c286d371f8f0383aa30d58b8ffc0579637
changeset:  9803b2c286d371f8f0383aa30d58b8ffc0579637
user:       Gregory Szorc <gps@mozilla.com>
date:       Fri Jul 17 14:30:48 2015 -0700
description:
requests: upgrade to requests 2.7.0 (bug 1184593); rs=smacleod

requests 2.3.0 is old and there are some bugs in it and urllib3 that are
nice to have. One of the fixed bugs prevents a ZeroReturnError from
causing havoc in the Selelnium tests.
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.