Top sites query limit races with collectionView creation

RESOLVED FIXED

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: wesj, Assigned: wesj)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
I noticed that we're requesting a limit of -75 (yes, minus) sites for top sites. Turns out to be because we set of the request when the profile-didSet method is called, but that may be before the collectionView is created (which we use to determine how big our list is).
(Assignee)

Comment 1

3 years ago
Created attachment 8634858 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/760

Dumb db mistakes are the best kind. This makes the collectionView optional and predicates starting the query on having it. 2s queries down to 500-600ms. Still a ways to go, but we're getting there...
Attachment #8634858 - Flags: review?(rnewman)
Boom!
Assignee: nobody → wjohnston
Status: NEW → ASSIGNED
Comment on attachment 8634858 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/760

LGTM with comments.
Attachment #8634858 - Flags: review?(rnewman) → review+
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.