Closed
Bug 1184728
Opened 9 years ago
Closed 9 years ago
URL and search bar are too big in Dev Edition theme on Windows 10
Categories
(Firefox :: Theme, defect, P2)
Firefox
Theme
Tracking
()
VERIFIED
FIXED
Firefox 42
People
(Reporter: bgrins, Assigned: bgrins)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
32.83 KB,
image/png
|
Details | |
40 bytes,
text/x-review-board-request
|
dao
:
review+
ritu
:
approval-mozilla-aurora+
|
Details |
The URL bar and search bar are now too big for the Dev Edition theme back button as of Bug 1173736. We don't want to set that min-height in the DE theme.
Assignee | ||
Comment 1•9 years ago
|
||
Screenshot
Assignee | ||
Updated•9 years ago
|
Flags: qe-verify+
Assignee | ||
Comment 2•9 years ago
|
||
This is the offending rule: https://hg.mozilla.org/mozilla-central/rev/c9a6fe3629ae#l2.12
Assignee | ||
Comment 3•9 years ago
|
||
Alternatively we could just make the back button bigger
Assignee | ||
Comment 4•9 years ago
|
||
Bug 1184728 - Make back and forward button vertical padding match the value defined in browser.css in Dev Edition theme;r=dao
Attachment #8634950 -
Flags: review?(dao)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Updated•9 years ago
|
Priority: -- → P2
Assignee | ||
Updated•9 years ago
|
Blocks: windows-10
Updated•9 years ago
|
Attachment #8634950 -
Flags: review?(dao) → review+
Updated•9 years ago
|
QA Contact: cornel.ionce
Assignee | ||
Comment 5•9 years ago
|
||
remote: https://hg.mozilla.org/integration/fx-team/rev/609f510f8c58
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/609f510f8c58
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 42
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8634950 [details] MozReview Request: Bug 1184728 - Make back and forward button vertical padding match the value defined in browser.css in Dev Edition theme;r=dao Approval Request Comment [Feature/regressing bug #]: 1173736 [User impact if declined]: the Windows 10 Dev Edition theme will look bad (see screenshot in this bug) [Describe test coverage new/current, TreeHerder]: [Risks and why]: Limited to Dev Edition theme only, and a pretty trivial fix [String/UUID change made/needed]:
Attachment #8634950 -
Flags: approval-mozilla-aurora?
Comment 8•9 years ago
|
||
Confirming this fix on latest Nightly, build ID: 20150721030212 using Windows 10 64-bit. Filled bug 1186351 as a follow-up for the HiDPI displays, where the back button is still too small.
Comment on attachment 8634950 [details] MozReview Request: Bug 1184728 - Make back and forward button vertical padding match the value defined in browser.css in Dev Edition theme;r=dao Fix was already verified, approved.
Attachment #8634950 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
status-firefox41:
--- → affected
Comment 11•9 years ago
|
||
Confirming the fix on Windows 10 64-bit. Tested on latest 42.0a2 Aurora (build ID: 20150910004036) as DevEdition in not available in Firefox 41.
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•