Closed Bug 1184728 Opened 4 years ago Closed 4 years ago

URL and search bar are too big in Dev Edition theme on Windows 10

Categories

(Firefox :: Theme, defect, P2)

defect

Tracking

()

VERIFIED FIXED
Firefox 42
Tracking Status
firefox41 --- fixed
firefox42 --- verified

People

(Reporter: bgrins, Assigned: bgrins)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

The URL bar and search bar are now too big for the Dev Edition theme back button as of Bug 1173736.  We don't want to set that min-height in the DE theme.
Attached image deved-urlbar-win10.png
Screenshot
Flags: qe-verify+
Alternatively we could just make the back button bigger
Bug 1184728 - Make back and forward button vertical padding match the value defined in browser.css in Dev Edition theme;r=dao
Attachment #8634950 - Flags: review?(dao)
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Priority: -- → P2
Blocks: windows-10
Attachment #8634950 - Flags: review?(dao) → review+
QA Contact: cornel.ionce
remote:   https://hg.mozilla.org/integration/fx-team/rev/609f510f8c58
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/609f510f8c58
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 42
Comment on attachment 8634950 [details]
MozReview Request: Bug 1184728 - Make back and forward button vertical padding match the value defined in browser.css in Dev Edition theme;r=dao

Approval Request Comment
[Feature/regressing bug #]: 1173736
[User impact if declined]: the Windows 10 Dev Edition theme will look bad (see screenshot in this bug)
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: Limited to Dev Edition theme only, and a pretty trivial fix
[String/UUID change made/needed]:
Attachment #8634950 - Flags: approval-mozilla-aurora?
Confirming this fix on latest Nightly, build ID: 20150721030212 using Windows 10 64-bit.

Filled bug 1186351 as a follow-up for the HiDPI displays, where the back button is still too small.
Status: RESOLVED → VERIFIED
Depends on: 1186351
Comment on attachment 8634950 [details]
MozReview Request: Bug 1184728 - Make back and forward button vertical padding match the value defined in browser.css in Dev Edition theme;r=dao

Fix was already verified, approved.
Attachment #8634950 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Depends on: 1187727
Depends on: 1179295
Confirming the fix on Windows 10 64-bit.
Tested on latest 42.0a2 Aurora (build ID: 20150910004036) as DevEdition in not available in Firefox 41.
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.