Closed Bug 1184737 Opened 5 years ago Closed 5 years ago

Windows 10 search rewrite should handle more results

Categories

(Firefox :: Search, defect, P2)

defect

Tracking

()

VERIFIED FIXED
Firefox 42
Tracking Status
firefox40 --- verified
firefox41 --- verified
firefox42 --- verified

People

(Reporter: Dolske, Assigned: Dolske)

References

Details

Attachments

(1 file)

Bug 1177237 added support for rewriting Win10 OS searches, for the main entry points where it offers "search the web". (EG, click in the search box, type "bacon", and press enter or explicitly select the top "Search the web" result).

However, the Cortana voice recognition feature encourages use as a more advanced digital assistant, and you can ask it free form questions / commands. (EG, saying "please open notepad" will open the notepad app, "what's the weather in toronto" will show an in-place weather applet). Asking it things that result in a web search (because it has no immediate answer) shows "See more results on Bing.com", instead of "Search the web". But they both do the same thing -- sends your question to bing.com as a search.

We should rewrite these URLs too, because it's a useful feature. The downside is that the Windows 10 UI will still imply the results will open on Bing, when it's actually going to the user's default search engine in Firefox. That's unfortunate, but Microsoft made the choice not to offer the user choice of different search engines. I've seen no special handling of these searches by Bing.
Attached patch Patch v.1Splinter Review
Add another FORM param check.
Assignee: nobody → dolske
Attachment #8634953 - Flags: review?(jaws)
Bryan and I talked about doing this, but NI to see if he wants to test this further or just land it.
Flags: needinfo?(clarkbw)
Priority: -- → P2
QA Contact: cornel.ionce
(In reply to Justin Dolske [:Dolske] from comment #2)
> Bryan and I talked about doing this, but NI to see if he wants to test this
> further or just land it.

LGTM
Flags: needinfo?(clarkbw)
url:        https://hg.mozilla.org/integration/fx-team/rev/7b33ab963ae7d646bdea76deb165e594be23c67c
changeset:  7b33ab963ae7d646bdea76deb165e594be23c67c
user:       Justin Dolske <dolske@mozilla.com>
date:       Fri Jul 17 13:24:25 2015 -0700
description:
Bug 1184737 - Windows 10 search rewrite should handle more results. r=jaws
https://hg.mozilla.org/mozilla-central/rev/7b33ab963ae7
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Comment on attachment 8634953 [details] [diff] [review]
Patch v.1

Approval Request Comment
[Feature/regressing bug #]: bug 1177237
[User impact if declined]: New feature has inconsistent behavior.
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: Very low risk, trivial change.
[String/UUID change made/needed]: n/a
Attachment #8634953 - Flags: approval-mozilla-beta?
Attachment #8634953 - Flags: approval-mozilla-aurora?
Comment on attachment 8634953 [details] [diff] [review]
Patch v.1

Seems safe to uplift to Aurora.
Attachment #8634953 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Florin, would you be able to verify this fix on 07/21 nightly or after? If all looks good, we can consider uplifting to Beta as well. I just approved Aurora uplift.
Flags: needinfo?(florin.mezei)
Comment on attachment 8634953 [details] [diff] [review]
Patch v.1

This is a trivial change. Let's take this in beta7 and verify there. Beta+
Attachment #8634953 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
As Lawrence stated, we'll verify this tomorrow in Beta 7.
Flags: needinfo?(florin.mezei)
Flags: qe-verify+
Verified as fixed on the latest build of Windows 10 64-bit using Firefox 40 beta 7 (build ID: 20150723165742).
Status: RESOLVED → VERIFIED
Confirming this on Windows 10 64-bit using:
*Firefox 40 beta 1, build ID: 20150811185633
*latest Aurora, build ID: 20150816004012.
You need to log in before you can comment on or make changes to this bug.