1184748 - Link to compare view from resultset view for talos jobs

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[William Lachance (:wlach)]

:BenWa suggested it would be handy to have a quick link to the comparison chooser in the Talos results for a job. By clicking on it, you'd get a quick link to the compare chooser with the revision/branch as the "new" result.

This involves two things:

1. allow the specification of url parameters for the compare chooser which prefill the form with results (i.e. https://treeherder.mozilla.org/perf.html#/comparechooser?newRevision=1234&newProject=fx-team)
2. add a link to the talos panel to this view. should just need to modify this file: https://github.com/mozilla/treeherder/blob/master/ui/plugins/talos/main.html

Comment 1

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=3798462
repository: fx-team
start_time: 2015-07-16T13:06:13
who: wkocher[at]mozilla[dot]com
machine: tst-linux64-spot-1851
buildname: Android 4.3 armv7 API 11+ fx-team opt test robocop-1
revision: 678356bb443a

TEST-UNEXPECTED-FAIL | testAboutPage | Exception caught - junit.framework.AssertionFailedError: LayerView is not found!
Return code: 1

Comment 2

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=3798476
repository: fx-team
start_time: 2015-07-16T13:07:59
who: wkocher[at]mozilla[dot]com
machine: tst-linux64-spot-1984
buildname: Android 4.3 armv7 API 11+ fx-team opt test robocop-1
revision: 678356bb443a

TEST-UNEXPECTED-FAIL | testAboutPage | Exception caught - junit.framework.AssertionFailedError: LayerView is not found!
Return code: 1

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

odd, the robot is recommending this to star stuff :(

we have bug 1162705 to solve #1.  In an ideal world it would fill in the chooser and you can select "previous revision" or enter a revision from another branch, like try or m-c.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

It was manually entered.

Comment 5

[MikeLing]

I would like to work on this if it's ok, due to the bug 1162705 is on my bug list :)

Comment 6

[MikeLing]

(In reply to Joel Maher (:jmaher) from comment #3)

I haven't use talos before, could you give me a link or picture shows me what's talos looks like? So I can figure out where should I put the link with. Thank you :)

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

this would require editing talos a slight bit, getting started with talos can be done here:
https://wiki.mozilla.org/Buildbot/Talos/Running#Running_locally_-_Source_Code

The talos stuff will not need to get signatures for this, we can just print out the direct link to the compare view.  I would print it out near the end of the run after we process results.  

The problem with compare view and local results is we are comparing results on a developer machine with different cpu/memory/processes to one of our reference machines- I see the desire for this, but I wouldn't want to go much further than generating a simple link to comparechooser.

Comment 8

[William Lachance (:wlach)]

It should not be necessary to modify talos for this. Instead, just modify the existing talos plugin for job data view to print a link to perfherder:

https://github.com/mozilla/treeherder/blob/master/ui/plugins/talos/main.html

Just print something like this at the end:

Compare this revision to a baseline on perfherder:  https://treeherder.mozilla.org/perf.html#/comparechooser?newProject={{projectName}}&newRevision={{revision}}

I believe it should be possible to retrieve the project name and revision information from the angular scope.

Comment 9

[MikeLing]

Attachment: PR for bug 1184748

Comment 10

[MikeLing]

Comment on attachment 8646316 [details] [review]
PR for bug 1184748

Due to Will told me he need to focus on something important issue, I decide to ask review from :Joel. Hope it's ok with you.

Comment 11

[William Lachance (:wlach)]

Comment on attachment 8646316 [details] [review]
PR for bug 1184748

I'll actually take this, if that's ok. This should be a fast one. :)

Comment 12

[William Lachance (:wlach)]

Comment on attachment 8646316 [details] [review]
PR for bug 1184748

This is perfect except for the text! Thanks for doing this. :)

Comment 13

[MikeLing]

Comment on attachment 8646316 [details] [review]
PR for bug 1184748

my pleasure :)

Comment 14

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/e8f23db660a9dc4d2da7b3750853a52853cf49ab
Bug 1184748 - Link to compare view from resultset view for talos jobs

https://github.com/mozilla/treeherder/commit/afe04d009cad641509ef340266ccc35f0de1baf6
Merge pull request #856 from MikeLing/bugfix-1184748

Bug 1184748 - Link to compare view from resultset view for talos jobs

Comment 15

[William Lachance (:wlach)]

Comment on attachment 8646316 [details] [review]
PR for bug 1184748

Merged, thank you!