Closed Bug 1184783 Opened 6 years ago Closed 6 years ago

FaviconFetcher should use a way of loading urls that uses our UserAgent

Categories

(Firefox for iOS :: Favicons, defect)

All
iOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
fxios + ---

People

(Reporter: wesj, Assigned: wesj)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

I landed this using NSData(contentsOfUrl) which uses a UA of "Client/15 CFNetwork/711.4.6 Darwin/14.0.0". That gives us just about the worst results possible. AlamoFire or any other HTTP client should do better :)
If we switch to Alamofire, see also Bug 1164140.
Blocks: 1151960
Attachment #8636841 - Flags: ui-review?(randersen)
Attachment #8636841 - Flags: ui-review?(dhenein)
Pinging UX, but I'm going to pull the frontend changes out into a separate PR to make this less scary.
Leaving the old PR in place for reference, but this cherry-picks just the user agent bits.
Attachment #8637430 - Flags: review?(bnicholson)
Assignee: nobody → wjohnston
Status: NEW → ASSIGNED
Component: Home screen → Favicons
Hardware: Other → All
Attachment #8637430 - Flags: review?(bnicholson) → review+
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Attachment #8636841 - Flags: ui-review?(dhenein) → ui-review-
You need to log in before you can comment on or make changes to this bug.