Closed
Bug 1184783
Opened 9 years ago
Closed 9 years ago
FaviconFetcher should use a way of loading urls that uses our UserAgent
Categories
(Firefox for iOS :: Favicons, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | + | --- |
People
(Reporter: wesj, Assigned: wesj)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
206 bytes,
text/plain
|
dhenein
:
ui-review-
|
Details |
|
47 bytes,
text/x-github-pull-request
|
bnicholson
:
review+
|
Details | Review |
I landed this using NSData(contentsOfUrl) which uses a UA of "Client/15 CFNetwork/711.4.6 Darwin/14.0.0". That gives us just about the worst results possible. AlamoFire or any other HTTP client should do better :)
|
||
Updated•9 years ago
|
tracking-fxios:
--- → ?
|
||
Comment 1•9 years ago
|
||
If we switch to Alamofire, see also Bug 1164140.
|
|
||
Updated•9 years ago
|
|
Assignee | |
Comment 2•9 years ago
|
||
Attachment #8636841 -
Flags: ui-review?(randersen)
Attachment #8636841 -
Flags: ui-review?(dhenein)
|
|
Assignee | |
Comment 3•9 years ago
|
||
Pinging UX, but I'm going to pull the frontend changes out into a separate PR to make this less scary.
|
|
Assignee | |
Comment 4•9 years ago
|
||
Leaving the old PR in place for reference, but this cherry-picks just the user agent bits.
Attachment #8637430 -
Flags: review?(bnicholson)
|
|
||
Updated•9 years ago
|
Assignee: nobody → wjohnston
Status: NEW → ASSIGNED
Component: Home screen → Favicons
Hardware: Other → All
|
||
Updated•9 years ago
|
Attachment #8637430 -
Flags: review?(bnicholson) → review+
|
|
Assignee | |
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
Attachment #8636841 -
Flags: ui-review?(dhenein) → ui-review-
You need to log in
before you can comment on or make changes to this bug.
Description
•