1184796 - Explore ways to combine output from bidi-style/value Stulys mixin

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Code Cleanup, defect)

Description

[Stephanie Hobson [:shobson]]

Current behaviour:

.test {
    bidi-value(float, left, right);
    bidi-value(text-align, left, right);
}

Outputs:

.test {
    float:left;
    text-align: left;
}
html[dir='rtl'] .test {
    float: right;
}
html[dir='rtl'] .test {
    text-align: right;
}

Ideal output: 

.test {
    float:left;
    text-align: left;
}
html[dir='rtl'] .test {
    float: right;
    text-align: right;
}

The solution to this may not lie with Stylus, we might be able to tweak the minifier to do it.

Comment 1

[[github robot]]

Commit pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/7e83c6bebdfb7f86087f5c8d4092a813a9cbf788
Fix bug 1184796: Optimize bibi mixin for multiple declarations (#4569)

- create bidi() mixin
- update all bidi-value and bidi-style includes to use bidi()