1184820 - update imagecompare tests to accomodate changes in Bug 1180819

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[No-Jun Park [:njpark]]

Existing imagecompare tests need to use new scroll/pinch method, as well as deal with the reduced time.sleep() duration before taking screenshot.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] npark-mozilla:update > mozilla-b2g:master

Comment 2

[Martijn Wargers (dead)]

Comment on attachment 8635091 [details] [review]
[gaia] npark-mozilla:update > mozilla-b2g:master

I ran one test, test_orientation_zoom.py, and that works. I got a failure, but that appears to be, because of the log, which shows slight differences between the 2 runs (perhaps the fuzz factor needs to be increased?).

Comment 3

[No-Jun Park [:njpark]]

(In reply to Martijn Wargers [:mwargers] (QA) from comment #2)
> Comment on attachment 8635091 [details] [review]
> [gaia] npark-mozilla:update > mozilla-b2g:master
> 
> I ran one test, test_orientation_zoom.py, and that works. I got a failure,
> but that appears to be, because of the log, which shows slight differences
> between the 2 runs (perhaps the fuzz factor needs to be increased?).

That's actually a good point, I've been meaning to increase the default fuzz factor to 20~25% because that seems to be more ideal tradeoff.

Comment 4

[No-Jun Park [:njpark]]

Merged:

https://github.com/mozilla-b2g/gaia/commit/a47e0c58dd1340a17be7cc96ccd90fcad15a922b