PerformanceEntry.entryType will be changed to enum

RESOLVED INVALID

Status

()

Core
DOM
RESOLVED INVALID
3 years ago
3 years ago

People

(Reporter: hiro, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Created attachment 8635120 [details] [diff] [review]
Change PerformanceEntry.entryType

The updated spec has not been merged yet.

https://github.com/w3c/performance-timeline/pull/37

This change is harmless in JS side so we can get this into our tree.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5527bbb2766
Attachment #8635120 - Flags: review?(amarchesini)
Comment on attachment 8635120 [details] [diff] [review]
Change PerformanceEntry.entryType

Review of attachment 8635120 [details] [diff] [review]:
-----------------------------------------------------------------

perfect.
Attachment #8635120 - Flags: review?(amarchesini) → review+
> This change is harmless in JS side 

It's not.  Before this change, getEntriesByType("some-new-type") would silently return empty list; after the change it throws.  It's not clear to me that we actually want this change to the spec; I commented on the PR.
(Reporter)

Comment 3

3 years ago
Boris, thanks for pointing it out. I did totally miss the issue.
(Reporter)

Comment 4

3 years ago
The change has been discarded.
https://github.com/w3c/performance-timeline/pull/37
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → INVALID
(Reporter)

Updated

3 years ago
No longer blocks: 1165796
You need to log in before you can comment on or make changes to this bug.