1184864 - [Android] Horizontal scroll on feed/editorial page on android

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Description

[Trishul]

Attachment: Screenshot_2015-07-17-13-10-06.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20150716004006

Steps to reproduce:

1. Goto https://marketplace.firefox.com/feed/editorial/games?src=branded-editorial-element on android mobile.
2. Swipe left


Actual results:

We get a horizontal scroll, distorting mobile layout


Expected results:

There should be no horizontal scroll.

Comment 1

[Trishul]

Checked on Firefox for android on Moto G2, happens in portrait as well as landscape mode.

Comment 2

[Ram Dayal Vaishnav [:ram]]

I am able to reproduce it.

Comment 3

[Trishul]

Attachment: Pull Request

Kindly review

Comment 4

[Trishul]

Any updates?

Comment 6

[David Durst [:ddurst]]

Trishul -- if you can make those last changes noted in the PR, this will be good to go.

Comment 7

[Trishul]

Created new PR
https://github.com/mozilla/fireplace/pull/1596

added overflow:hidden to .feed-landing-header-mobile instead of .feed-landing-header, so that it doesnt regress to desktop :)

Comment 8

[Trishul]

Hi, when I submitted the PR all check passed, in addition its just a line of CSS, I fail to understand why the travis check failed ?

Comment 9

[Davor Spasovski [:spasovski]]

The test itself is flaky with reasons unrelated to your PR. We can merge the fix and address the test issues separately.

Comment 10

[Trishul]

PR Merged

https://github.com/mozilla/fireplace/pull/1596